Skip to content

fix CustomEvent constructor compatibility #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2025
Merged

fix CustomEvent constructor compatibility #2074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff6420a
fix(g-lite): fix CustomEvent constructor compatibility
wang1212 Oct 20, 2025
7d014bd
chore: adjust ESLint ignore file to improve development workflow
wang1212 Oct 21, 2025
e788d99
Update packages/g-lite/src/dom/CustomEvent.ts
wang1212 Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silver-hornets-warn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@antv/g-lite': patch
---

fix(g-lite): fix CustomEvent constructor compatibility
1 change: 1 addition & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ build/
lib/
esm/
coverage/
types/

# 依赖目录
node_modules/
Expand Down
5 changes: 5 additions & 0 deletions packages/g-lite/src/dom/CustomEvent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ export class CustomEvent<
this.type = eventName;
this.detail = options?.detail;

// compatible
if (options && !('detail' in options)) {
this.detail = options;
}

// compatible with G 3.0
Object.assign(this, options);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/g-lite/src/dom/EventTarget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export class EventTarget implements IEventTarget {
* @alias dispatchEvent
*/
emit(eventName: string, object: object) {
this.dispatchEvent(new CustomEvent(eventName, { detail: object }));
this.dispatchEvent(new CustomEvent(eventName, object));
}

private dispatchEventToSelf<T extends FederatedEvent>(e: T) {
Expand Down
Loading