Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade antrea to v1.13.0 #413

Merged
merged 2 commits into from
Aug 15, 2023
Merged

upgrade antrea to v1.13.0 #413

merged 2 commits into from
Aug 15, 2023

Conversation

yuntanghsu
Copy link
Contributor

@yuntanghsu yuntanghsu commented Aug 2, 2023 •
edited
Loading

  • k8s.io/apimachinery/pkg/util/sets.String was deprecated, and replaced with sets.Set[string]. sets.String.List() was replaced with sets.List(sets.Set[string]). Similar changes happened on sets.Int32, sets.Int64
  • k8s.io/apiserver/pkg/registry/rest.Storage interface added requirement on implementation of Destroy() method
  • k8s.io/client-go/tools/remotecommand.Executor.Stream was deprecated, and replaced with StreamWithContext
  • NetworkPolicy struct is updated from crdv1alpha1 to v1beta1
  • ANPAppliedToSpec is renamed to ANNPAppliedToSpec
  • "k8s.io/kubectl/pkg/cmd/cp" changed the way to take the parameter args. CopyOptions no longer takes the parameter args in copyOptions.Run. User's defined args are used in copyOptions.Complete instead.

Signed-off-by: Yun-Tang Hsu hsuy@vmware.com

@yuntanghsu yuntanghsu marked this pull request as draft August 2, 2023 16:53
@codecov
Copy link

codecov bot commented Aug 2, 2023 •
edited
Loading

Codecov Report

Merging #413 (a4b2d6a) into main (68492cc) will decrease coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is 57.89%.

❗ Current head a4b2d6a differs from pull request most recent head 02669c2. Consider uploading reports for the commit 02669c2 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   71.43%   71.37%   -0.06%     
==========================================
  Files          40       40              
  Lines        5220     5234      +14     
==========================================
+ Hits         3729     3736       +7     
- Misses       1322     1328       +6     
- Partials      169      170       +1
Flag Coverage Δ *Carryforward flag
kind-e2e-tests 63.99% <57.89%> (-0.38%) ⬇️
python-coverage 56.37% <ø> (ø) Carriedforward from a31fba2
unit-tests 70.27% <0.00%> (-0.30%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
pkg/support/dump.go 50.49% <57.89%> (-0.04%) ⬇️

@yuntanghsu yuntanghsu force-pushed the upgrade_antrea_1.12 branch 9 times, most recently from 988300a to 2f9a41e Compare August 3, 2023 00:08
@yuntanghsu yuntanghsu changed the title upgrade antrea to v1.12 upgrade antrea to v1.13.0 Aug 3, 2023
@yuntanghsu
Copy link
Contributor Author

/theia-test-e2e

@yuntanghsu yuntanghsu marked this pull request as ready for review August 3, 2023 02:26
@yuntanghsu
Copy link
Contributor Author

/theia-test-e2e

@yuntanghsu yuntanghsu force-pushed the upgrade_antrea_1.12 branch 3 times, most recently from a4b2d6a to 081f261 Compare August 4, 2023 22:24
@yuntanghsu
upgrade antrea to v1.12
30c8f25 
Signed-off-by: Yun-Tang Hsu <hsuy@vmware.com>
heanlan
heanlan reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@heanlan heanlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

I suggest we list out the notable changes in the PR description, as an example: antrea-io/antrea#4935

pkg/support/dump.go
copyOptions.Namespace = namespace

if err := copyOptions.Run([]string{pod + ":" + srcDir, dstDir}); err != nil {
factory := util.NewFactory(newRestClientGetter(namespace, d.restConfig))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, where are the changes of this file coming from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is because k8s.io/kubectl is updated from v0.24.0 to v0.26.4. copyOptions also changed the way it takes args in v0.26.4. Previously, it took args when we called copyOptions.Run(args). But the args can only be set in copyOptions.Complete now. I can't find the usage of new copyOptions, so I followed its library to create util.Factory and *cobra.Command, which will be used in copyOptions.Complete.

dreamtalen
dreamtalen approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@dreamtalen dreamtalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits only, LGTM.

pkg/support/dump.go Outdated Show resolved Hide resolved
pkg/support/dump.go Outdated Show resolved Hide resolved
@yuntanghsu
Upgrade antrea to v1.13.0
02669c2 
Signed-off-by: Yun-Tang Hsu <hsuy@vmware.com>
@yuntanghsu
Copy link
Contributor Author

/theia-test-e2e

heanlan
heanlan approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@heanlan heanlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuntanghsu
Copy link
Contributor Author

/theia-test-e2e

@yuntanghsu yuntanghsu merged commit ffeafb6 into antrea-io:main Aug 15, 2023
44 of 45 checks passed
@yuntanghsu yuntanghsu deleted the upgrade_antrea_1.12 branch August 15, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamtalen dreamtalen dreamtalen approved these changes

@heanlan heanlan heanlan approved these changes

@tushartathgur tushartathgur Awaiting requested review from tushartathgur

@yanjunz97 yanjunz97 Awaiting requested review from yanjunz97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuntanghsu @dreamtalen @heanlan