Bugfix: unmarshal issue with byte slice in packetIn2 message #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnqn
reviewed
Jun 19, 2023
ofctrl/ofSwitch.go
Outdated
| PropHeader: &openflow15.PropHeader{ | ||
| Type: openflow15.NXPINT_CONTINUATION, | ||
| }, | ||
| } | ||
| copy(continueProp.Continuation[0:], pktIn.Continuation) |
wenyingd
force-pushed
the
unmarshal_with_bytes
branch
from
52e4c68 to
087e990
Compare
tnqn
previously approved these changes
Jun 19, 2023
|
Unit test is added in libOpenflow, https://github.com/antrea-io/libOpenflow/pull/40/files#diff-f180594e31676b495e8995fc65b51f3d3499d5f5adbfb5affe965190aed1c137R119 |
Use "copy" function to set the byte slice fields in a message. Signed-off-by: wenyingd <wenyingd@vmware.com>
wenyingd
force-pushed
the
unmarshal_with_bytes
branch
from
087e990 to
1d43665
Compare
|
Updated |
tnqn
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "copy" function to set the byte slice fields in a message.