Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crictl version to v1.31.1 #6733

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

luolanzone
Copy link
Contributor

@luolanzone luolanzone commented Oct 11, 2024

No description provided.

@luolanzone luolanzone self-assigned this Oct 11, 2024
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed this warning, however this is not a great approach to tackling it:

  • IMO, we shouldn't add a tag that doesn't exist (such as latest for antrea/base-ubuntu)
  • having a specific version as the tag (e.g., ARG GO_VERSION=1.23) defeats the purpose of having one source of truth for the version, and means a larger diff when bumping up the dependency
  • when building and forgetting the tag (e.g., from a script), it's better to have an error (missing tag) rather than build with the wrong "default" tag. This type of issue can create surprising behaviors and be hard to troubleshoot.

#6486 should reduce the amount of warnings. We could do something similar for the golang image and use a build context. Otherwise, I would suggest silencing that specific warning for now.

@luolanzone luolanzone changed the title Set default values to fix InvalidDefaultArgInFrom warning Update crictl version and remove unused args Oct 12, 2024
@luolanzone
Copy link
Contributor Author

Hi @antoninbas I have reverted the change and made some cleanup only, PTAL, thanks.

@luolanzone
Copy link
Contributor Author

Ah, I just noticed that you already removed unused args in the PR #6486, thanks for that. I think we still need to update crictl's version to 1.31.1 but it's not critical, do you want to include the change in your PR or keep in this PR?

@antoninbas
Copy link
Contributor

Ah, I just noticed that you already removed unused args in the PR #6486, thanks for that. I think we still need to update crictl's version to 1.31.1 but it's not critical, do you want to include the change in your PR or keep in this PR?

I think we can have a dedicated PR to update the crictl version

Signed-off-by: Lan Luo <luola@vmware.com>
@luolanzone luolanzone changed the title Update crictl version and remove unused args Update crictl version to v1.31.1 Oct 16, 2024
@antoninbas antoninbas merged commit 3177ea2 into antrea-io:main Oct 16, 2024
45 of 57 checks passed
@luolanzone luolanzone deleted the fix-warning branch October 17, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants