Always require the cluster UUID in the FlowAggregator #6714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the cluster UUID was strictly required by the S3Exporter and by the ClickHouseExporter, but somewhat optional for the IPFIXExporter (if not available after a certain timeout, a random UUID was generated and used to compute the IPFIX observation domain ID). Furthermore, every exporter by responsible for calling getClusterUUID independently, and that was the only reason for their implementations to require access to the K8s client. I think it makes more sense to make things more uniform, and require the cluster UUID to be available regardless of which exporters are enabled. We can retrieve the cluster UUID once during FlowAggrgator initialization, then pass it along to all exporters which need it. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas
added
the
area/flow-visibility/aggregator
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the cluster UUID was strictly required by the S3Exporter and by the ClickHouseExporter, but somewhat optional for the IPFIXExporter (if not available after a certain timeout, a random UUID was generated and used to compute the IPFIX observation domain ID). Furthermore, every exporter by responsible for calling getClusterUUID independently, and that was the only reason for their implementations to require access to the K8s client.
I think it makes more sense to make things more uniform, and require the cluster UUID to be available regardless of which exporters are enabled. We can retrieve the cluster UUID once during FlowAggrgator initialization, then pass it along to all exporters which need it.