Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NodePortLocal rules being deleted incorrectly due to PodIP recycle #6531

Merged
merged 1 commit into from
Jul 18, 2024

Commits on Jul 18, 2024

  1. Fix NodePortLocal rules being deleted incorrectly due to PodIP recycle

    The NodePortLocal cache bound a Pod's NodePortLocal rules to its Pod IP.
    However, a Pod IP can be recycled and allocated to another Pod when it
    runs into succeeded or failed stage, which causes more than one Pod to
    share a Pod IP. When the terminated Pod was deleted, NodePortLocal
    controller incorrectly deleted the rules that belong to another Pod
    because they have the same IP.
    
    The patch fixes it by binding the NodePortLocal rules to its Pod key
    (namespace + name). The podToIP cache is no longer needed as we can
    clean up rules by Pod key.
    
    Signed-off-by: Quan Tian <quan.tian@broadcom.com>
    tnqn committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    bfd099c View commit details
    Browse the repository at this point in the history