Refactor pkg/agent/proxy/proxier_test.go #6420
Conversation
hongliangl
added
the
area/test
hongliangl
force-pushed
the
20240607-refactor-proxy-test
branch
from
27aa9ef
to
9205888
Compare
pkg/agent/proxy/proxier_test.go
Outdated
| loadBalancerIPs []net.IP, | ||
| updatedLoadBalancerIPs []net.IP, | ||
| isIPv6 bool) { | ||
| func testServiceIngressIPsAndExternalIPsUpdate(t *testing.T, bindingProtocol binding.Protocol, isIPv6 bool) { |
There was a problem hiding this comment.
why rename this test? I think that "ExternalIPs" would be included in the term "IngressIPs", just like "LoadbalancerIP".
There was a problem hiding this comment.
How about renaming it to testServiceExternalIPsUpdate? I saw that externalIP is used to represent LoadBalncerIP and externalIP in our code:
antrea/pkg/agent/route/route_linux.go
Line 1756 in 676fc98
There was a problem hiding this comment.
I renamed this because I thought that the term ingresIPs is an alias of the term LoadBalancerIP.
There was a problem hiding this comment.
I actually think that IngressIPs is less ambiguous in this case (given that ExternalIPs is a specific kind of Service IP in itself), but I don't feel very strongly either way.
Refine test functions with multiple parameters and add some UDP Service tests. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl
force-pushed
the
20240607-refactor-proxy-test
branch
from
9205888
to
7f071f6
Compare
|
/skip-all |
tnqn
added
the
kind/cleanup
Refine test functions with multiple parameters and add some UDP Service tests.