Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rule name in iptables rule comment for NodeNetworkPolicy #6315

Merged

Conversation

hongliangl
Copy link
Contributor

To improve the readability of iptables rules installed for NodeNetworkPolicy, the rule name, which is more meaningful, instead of rule ID, which is a unique string, is used in the corresponding iptables rule.

To improve the readability of iptables rules installed for NodeNetworkPolicy,
the rule name, which is more meaningful, instead of rule ID, which is a unique
string, is used in the corresponding iptables rule.

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
@hongliangl hongliangl requested a review from tnqn May 10, 2024 06:19
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented May 10, 2024

/skip-all

@tnqn tnqn merged commit 51df806 into antrea-io:main May 10, 2024
50 of 54 checks passed
@hongliangl hongliangl deleted the 20240510-refine-nnp-iptables-comment branch May 10, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants