-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not run tests when building OVS for UBI #6104
Do not run tests when building OVS for UBI #6104
Conversation
This change adds back the default `RPMBUILD_OPT` to disable unnecessary tests when building OVS rpm packages, which was previously overwritten in antrea-io#6052. Signed-off-by: Xu Liu <xu.liu@broadcom.com>
d5643aa
to
be93e46
Compare
# See https://github.com/openvswitch/ovs/blob/v2.17.7/rhel/openvswitch-fedora.spec.in#L26-L27. | ||
RPMBUILD_OPT="--without libcapng" make rpm-fedora && mkdir -p /tmp/ovs-rpms && \ | ||
RPMBUILD_OPT="--without libcapng --without check" make rpm-fedora && mkdir -p /tmp/ovs-rpms && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the default when RPMBUILD_OPT
is not explicitly set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Please refer to https://github.com/openvswitch/ovs/blob/v2.17.7/rhel/automake.mk#L60
/skip-all |
This change adds back the default `RPMBUILD_OPT` to disable unnecessary tests when building OVS rpm packages, which was previously overwritten in antrea-io#6052. Signed-off-by: Xu Liu <xu.liu@broadcom.com>
This change adds back the default `RPMBUILD_OPT` to disable unnecessary tests when building OVS rpm packages, which was previously overwritten in antrea-io#6052. Signed-off-by: Xu Liu <xu.liu@broadcom.com>
This change adds back the default `RPMBUILD_OPT` to disable unnecessary tests when building OVS rpm packages, which was previously overwritten in #6052. Signed-off-by: Xu Liu <xu.liu@broadcom.com>
This change adds back the default
RPMBUILD_OPT
option to disable unnecessary tests when building OVS rpm packages, which was previously overwritten in #6052.