Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Jenkins Job for Windows OVS containerization #5603

Merged
merged 1 commit into from
May 21, 2024
Merged

Add Jenkins Job for Windows OVS containerization #5603

merged 1 commit into from
May 21, 2024

Conversation

NamanAg30
Copy link
Contributor

@NamanAg30 NamanAg30 commented Oct 19, 2023 •
edited by jainpulkit22
Loading

Following CI jobs are added as a part of jenkins job for Windows OVS containerization

  1. Add new jobs to run e2e, conformance and networkpolicy tests on testbed with Containerd runtime and
    OVS running inside container.

  2. Add job to allow skiping windows e2e, conformance and networkpolicy jobs with trigger phrases skip-windows-e2e, skip-windows-conformance and skip-windows-networkpolicy respectively, also one can make use of skip-all to skip running all the three jobs.

  3. Add period job for OVS userspace daemons running as Windows services

For #5325

rajnkamr
rajnkamr reviewed Oct 19, 2023
View reviewed changes
ci/jenkins/test.sh Outdated Show resolved Hide resolved
rajnkamr
rajnkamr reviewed Oct 19, 2023
View reviewed changes
ci/jenkins/test.sh Outdated Show resolved Hide resolved
@rajnkamr rajnkamr added this to the Antrea v1.14 release milestone Oct 19, 2023
XinShuYang
XinShuYang reviewed Oct 19, 2023
View reviewed changes
ci/jenkins/test.sh Outdated Show resolved Hide resolved
Atish-iaf
Atish-iaf reviewed Oct 19, 2023
View reviewed changes
ci/jenkins/jobs/projects-lab.yaml Outdated Show resolved Hide resolved
ci/jenkins/jobs/projects-lab.yaml Outdated Show resolved Hide resolved
ci/jenkins/jobs/projects-lab.yaml Outdated Show resolved Hide resolved
ci/jenkins/test.sh Outdated Show resolved Hide resolved
ci/jenkins/jobs/projects-lab.yaml Outdated Show resolved Hide resolved
ci/jenkins/jobs/projects-lab.yaml Outdated Show resolved Hide resolved
ci/jenkins/jobs/projects-lab.yaml Outdated Show resolved Hide resolved
ci/jenkins/jobs/projects-lab.yaml Outdated Show resolved Hide resolved
ci/jenkins/test.sh Outdated Show resolved Hide resolved
ci/jenkins/jobs/projects-lab.yaml Outdated Show resolved Hide resolved
@rajnkamr rajnkamr added area/OS/windows Issues or PRs related to the Windows operating system. area/test/jenkins Issue about jenkins setup code labels Oct 20, 2023
@NamanAg30 NamanAg30 marked this pull request as ready for review October 20, 2023 09:59
@rajnkamr
Copy link
Contributor

rajnkamr commented Nov 7, 2023

@NamanAg30 ,
let's resolve conflict and rebase branch wrt latest

@NamanAg30 NamanAg30 force-pushed the cicontainerdovs branch 2 times, most recently from 7c5a140 to c65ef4c Compare November 8, 2023 07:47
XinShuYang
XinShuYang reviewed Nov 14, 2023
View reviewed changes
ci/jenkins/test.sh Outdated Show resolved Hide resolved
@XinShuYang
Copy link
Contributor

Please update commit message and PR description.

rajnkamr
rajnkamr reviewed May 7, 2024
View reviewed changes
ci/jenkins/test.sh Outdated Show resolved Hide resolved
@rajnkamr rajnkamr changed the title Add jenkins job for Windows OVS containerization Add Jenkins Job for Windows OVS containerization May 7, 2024
@luolanzone luolanzone mentioned this pull request May 8, 2024
Closed
3 tasks
XinShuYang
XinShuYang reviewed May 8, 2024
View reviewed changes
ci/jenkins/test.sh Outdated Show resolved Hide resolved
@XinShuYang
Copy link
Contributor

/test-windows-containerd-e2e

XinShuYang
XinShuYang previously approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@XinShuYang XinShuYang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reminder: Based on the previous discussion, once this PR is merged, we should mark the jenkins-windows-e2e test as a mandatory pre-merge check, which means it can only be bypassed with specific skip commands like /skip-all or /skip-windows-e2e.

@XinShuYang
Copy link
Contributor

/test-windows-containerd-conformance
/test-windows-containerd-networkpolicy

wenyingd
wenyingd reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad to see that kube-proxy for Windows is removed.

ci/jenkins/jobs/macros.yaml Show resolved Hide resolved
ci/jenkins/jobs/projects-lab.yaml Outdated Show resolved Hide resolved
@jainpulkit22 jainpulkit22 force-pushed the cicontainerdovs branch 2 times, most recently from eb1105f to e9f07fe Compare May 20, 2024 08:04
@XinShuYang
Copy link
Contributor

/test-windows-all

XinShuYang
XinShuYang previously approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@XinShuYang XinShuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

antoninbas
antoninbas previously approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ci/jenkins/jobs/projects-lab.yaml Outdated Show resolved Hide resolved
@NamanAg30 @jainpulkit22
Add jenkins job for Windows OVS containerization
802f64b 
Add new jobs to run e2e, conformance and networkpolicy tests on testbed
with Containerd runtime and OVS running inside container.

Signed-off-by: Naman Agarwal <naman.agarwal75@gmail.com>
Signed-off-by: Pulkit Jain <pulkit.jain@broadcom.com>
@jainpulkit22 jainpulkit22 dismissed stale reviews from antoninbas and XinShuYang via 802f64b May 21, 2024 05:09
@antoninbas
Copy link
Contributor

@XinShuYang @jainpulkit22 did all the Windows tests pass before the last push?

@jainpulkit22
Copy link
Contributor

@XinShuYang @jainpulkit22 did all the Windows tests pass before the last push?

yes

@antoninbas antoninbas merged commit 62ed622 into antrea-io:main May 21, 2024
48 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyingd wenyingd wenyingd left review comments

@rajnkamr rajnkamr rajnkamr left review comments

@jainpulkit22 jainpulkit22 jainpulkit22 left review comments

@Atish-iaf Atish-iaf Atish-iaf left review comments

@luolanzone luolanzone luolanzone left review comments

@antoninbas antoninbas antoninbas approved these changes

@XinShuYang XinShuYang XinShuYang left review comments

@tnqn tnqn Awaiting requested review from tnqn

Assignees

@jainpulkit22 jainpulkit22

Labels
area/OS/windows Issues or PRs related to the Windows operating system. area/test/jenkins Issue about jenkins setup code kind/documentation Categorizes issue or PR as related to a documentation.
Projects
None yet
Milestone
Antrea v2.1 release
Development

Successfully merging this pull request may close these issues.
8 participants
@NamanAg30 @rajnkamr @XinShuYang @jainpulkit22 @antoninbas @wenyingd @Atish-iaf @luolanzone