[WIP][VM Agent] Support antctl for VM Agent #5472
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, antctl is not supported for VM Agent and running antctl on VM Agent will be treated as controller mode which causes unexpected output. This change introduces a new global flag called mode for antctl. It can be controller, agent, vm or flowaggregator. If the flag is not set, we will keep identifying mode by using environment vairables and Pod names like before. But if the flag is set, it has higer priority and the flag must be set for VM mode. This patch also adjusts some commands for VM mode. Current supported commands and their example outputs are listed below. antctl version --mode vm agentVersion: 1.14.0-dev-8c8f1869.dirty antctlVersion: v1.14.0-dev-f5c34dd4.dirty antctl get agentinfo --mode vm NODE STATUS NETWORK-POLICIES ADDRESS-GROUPS APPLIED-TO-GROUPS mengdie-vm-ubu Healthy 1 1 1 antctl get networkpolicy --mode vm NAME APPLIED-TO RULES SOURCE TIER-PRIORITY PRIORITY 4e1c09e7-eb5d-496e-8c89-0f038ee9d104 9a47b91d-76f1-5b82-a456-3816a3514090 1 AntreaNetworkPolicy:vm-ns/anp1 250 9000 antctl get appliedtogroup --mode vm NAME PODS EXTERNAL-ENTITIES 9a47b91d-76f1-5b82-a456-3816a3514090 <NONE> vm-ns/mengdie-vm-ubu antctl get addressgroup --mode vm NAME POD-IPS NODE-IPS EXTERNAL-ENTITY-IPS 9a47b91d-76f1-5b82-a456-3816a3514090 <NONE> <NONE> 172.16.100.2 Signed-off-by: Mengdie Song <songm@vmware.com>
mengdie-song
changed the title
luolanzone
added
the
action/release-note
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days |
github-actions
bot
added
the
lifecycle/stale
luolanzone
removed
the
lifecycle/stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, antctl is not supported for VM Agent and running antctl on VM Agent will be treated as controller mode which causes unexpected output.
This change introduces a new global flag called mode for antctl. It can be controller, agent, vm or flowaggregator. If the flag is not set, we will keep identifying mode by using environment vairables and Pod names like before. But if the flag is set, it has higer priority and the flag must be set for VM mode.
This patch also adjusts some commands for VM mode. Current supported commands and their example outputs are listed below.