Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FQDN upper-case issue #4934

Merged
merged 1 commit into from
May 5, 2023
Merged

Fix FQDN upper-case issue #4934

merged 1 commit into from
May 5, 2023

Conversation

GraysonWu
Copy link
Contributor

Fixes #4858

@GraysonWu
Copy link
Contributor Author

/test-all

@GraysonWu
Copy link
Contributor Author

/test-networkpolicy
/test-all-features-conformance

@GraysonWu GraysonWu requested review from tnqn and Dyanngg May 4, 2023 21:42
Dyanngg
Dyanngg reviewed May 4, 2023
View reviewed changes
Copy link
Contributor

@Dyanngg Dyanngg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, thanks for the fix

test/e2e/antreapolicy_test.go Show resolved Hide resolved
@Dyanngg Dyanngg requested a review from antoninbas May 4, 2023 22:05
@GraysonWu
Fix FQDN upper-case issue
3a5317d 
Signed-off-by: graysonwu <wgrayson@vmware.com>
@GraysonWu
Copy link
Contributor Author

GraysonWu commented May 4, 2023 •
edited
Loading

From my understanding, this should be backported to 1.3.0.

@tnqn tnqn added this to the Antrea v1.12 release milestone May 5, 2023
antoninbas
antoninbas approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor

antoninbas commented May 5, 2023 •
edited
Loading

From my understanding, this should be backported to 1.3.0.

We are not exactly doing patch releases for 1.3 any more, but it could / should be backported to 1.11 and 1.10

@GraysonWu
Copy link
Contributor Author

/test-all

@GraysonWu
Copy link
Contributor Author

/test-networkpolicy

@antoninbas antoninbas added the action/backport Indicates a PR that requires backports. label May 5, 2023
@antoninbas antoninbas merged commit 234f5cf into antrea-io:main May 5, 2023
This was referenced May 5, 2023
Merged
Merged
@tnqn tnqn added the action/release-note Indicates a PR that should be included in release notes. label May 9, 2023
ceclinux pushed a commit to ceclinux/antrea that referenced this pull request Jun 5, 2023
@GraysonWu @ceclinux
Support upper-case DNS names in FQDN policy rules (antrea-io#4934)
1b76515 
Fixes antrea-io#4858

Signed-off-by: graysonwu <wgrayson@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dyanngg Dyanngg Dyanngg left review comments

@antoninbas antoninbas antoninbas approved these changes

@tnqn tnqn Awaiting requested review from tnqn

Assignees
No one assigned
Labels
action/backport Indicates a PR that requires backports. action/release-note Indicates a PR that should be included in release notes.
Projects
None yet
Milestone
Antrea v1.12 release
Development

Successfully merging this pull request may close these issues.

FQDN netpol only works with lower case
4 participants
@GraysonWu @antoninbas @Dyanngg @tnqn