Log command output when the probe result doesn't match expectation #4912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiyueyao
reviewed
Apr 27, 2023
| actualResult = Connected | ||
| } | ||
| if expectedResult != nil && *expectedResult != actualResult { | ||
| log.Infof("%s -> %s: expected %s but got %s: err - %v /// stdout - %s /// stderr - %s", podName, dstName, *expectedResult, actualResult, err, stdout, stderr) |
There was a problem hiding this comment.
log.Tracef might be more suitable than log.Infof here, also keeping consistency in this file.
There was a problem hiding this comment.
I think that means we can only see the log when the test itself changes the log level to Trace, which could cause flood of logs generated by the matrix?
The point of the new log is that it only logs the error when it doesn't match the expectation. So if everything works fine, there is no verbose trace logs. If one probe fails, we can find detailed outputs with this probe only.
Dyanngg
previously approved these changes
Apr 27, 2023
The NetworkPolicy e2e tests have been failing randomly for some time. However, it was really hard to get useful information from the "reachability" comparison. This patch logs the probe command's detailed output when the result doesn't match expectation. Signed-off-by: Quan Tian <qtian@vmware.com>
tnqn
force-pushed
the
improve-test-debug
branch
from
30bbb4c
to
58caf24
Compare
tnqn
commented
Apr 28, 2023
Comment on lines
-163
to
-164
| // log this error as trace since may be an expected failure | ||
| log.Tracef("%s -> %s: error when running command: err - %v /// stdout - %s /// stderr - %s", podName, dstName, err, stdout, stderr) |
There was a problem hiding this comment.
removed the duplicate log in the latest patch
qiyueyao
approved these changes
Apr 28, 2023
|
/skip-all |
rajnkamr
pushed a commit
to rajnkamr/antrea
that referenced
this pull request
May 4, 2023
…ntrea-io#4912) The NetworkPolicy e2e tests have been failing randomly for some time. However, it was really hard to get useful information from the "reachability" comparison. This patch logs the probe command's detailed output when the result doesn't match expectation. Signed-off-by: Quan Tian <qtian@vmware.com>
ceclinux
pushed a commit
to ceclinux/antrea
that referenced
this pull request
Jun 5, 2023
…ntrea-io#4912) The NetworkPolicy e2e tests have been failing randomly for some time. However, it was really hard to get useful information from the "reachability" comparison. This patch logs the probe command's detailed output when the result doesn't match expectation. Signed-off-by: Quan Tian <qtian@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NetworkPolicy e2e tests have been failing randomly for some time. However, it was really hard to get useful information from the "reachability" comparison. This patch logs the probe command's detailed output when the result doesn't match expectation.