-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OVS table name as label for ovs_flow_count Prometheus metrics #4893
Conversation
13ff036
to
0ad9e37
Compare
@cr7258 Thanks for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment, otherwise LGTM
IMO, this is a safe change because:
- I consider it to be backward-compatible. Previous user queries should not be impacted.
- This should not increase the cardinality of the metric, as the 2 labels (table_id and table_name) are essentially synonyms (for each table_id, we have one and only one table_name).
pkg/agent/metrics/prometheus.go
Outdated
@@ -79,9 +79,9 @@ var ( | |||
Namespace: metricNamespaceAntrea, | |||
Subsystem: metricSubsystemAgent, | |||
Name: "ovs_flow_count", | |||
Help: "Flow count for each OVS flow table. The TableID is used as a label.", | |||
Help: "Flow count for each OVS flow table. The TableID and TableName are used as a label.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/are used as a label./are used as labels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed: 2cd9507
Signed-off-by: Cheng, Seven <seven.cheng@sap.com>
Signed-off-by: Cheng, Seven <seven.cheng@sap.com>
Signed-off-by: Cheng, Seven <seven.cheng@sap.com>
0fa98ae
to
2cd9507
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution
/test-all |
…trea-io#4893) Signed-off-by: Cheng, Seven <seven.cheng@sap.com> Co-authored-by: Cheng, Seven <seven.cheng@sap.com>
…trea-io#4893) Signed-off-by: Cheng, Seven <seven.cheng@sap.com> Co-authored-by: Cheng, Seven <seven.cheng@sap.com>
Issue: #4566
Add the OVS table name as a label for the
antrea_agent_ovs_flow_count
metric to facilitate identifying the corresponding table for each metric.