-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds unit test for pkg/antctl/raw/proxy/command.go #4891
Conversation
2fb2903
to
b8b809d
Compare
8e93a35
to
ec184dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, two nits
640978e
to
24ec937
Compare
dff55be
to
290d3ee
Compare
pkg/antctl/raw/proxy/command_test.go
Outdated
if err != nil { | ||
require.NoError(t, err) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just require.NoError(t, err)
, there is no if
statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, done.
Signed-off-by: KMAnju-2021 <km074btcse18@igdtuw.ac.in>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-e2e |
/test-e2e |
Signed-off-by: KMAnju-2021 <km074btcse18@igdtuw.ac.in>
Adds unit test for pkg/antctl/raw/proxy/command.go
for #4142
Signed-off-by: KMAnju-2021 km074btcse18@igdtuw.ac.in