Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds unit test for pkg/antctl/raw/proxy/command.go #4891

Merged
merged 1 commit into from
May 16, 2023

Conversation

KMAnju-2021
Copy link
Contributor

@KMAnju-2021 KMAnju-2021 commented Apr 20, 2023

Adds unit test for pkg/antctl/raw/proxy/command.go
for #4142
Signed-off-by: KMAnju-2021 km074btcse18@igdtuw.ac.in

@luolanzone luolanzone added the area/test Issues or PRs related to unit and integration tests. label Apr 23, 2023
@KMAnju-2021 KMAnju-2021 requested a review from luolanzone April 25, 2023 07:37
pkg/antctl/raw/proxy/command.go Outdated Show resolved Hide resolved
pkg/antctl/raw/proxy/command.go Outdated Show resolved Hide resolved
pkg/antctl/raw/proxy/command_test.go Outdated Show resolved Hide resolved
@rajnkamr rajnkamr added this to the Antrea v1.12 release milestone Apr 27, 2023
@KMAnju-2021 KMAnju-2021 force-pushed the ut-tests branch 6 times, most recently from 2fb2903 to b8b809d Compare May 4, 2023 08:42
@KMAnju-2021 KMAnju-2021 force-pushed the ut-tests branch 4 times, most recently from 8e93a35 to ec184dd Compare May 8, 2023 09:10
@KMAnju-2021 KMAnju-2021 requested a review from luolanzone May 8, 2023 09:32
Copy link
Contributor

@luolanzone luolanzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, two nits

pkg/antctl/raw/proxy/command_test.go Show resolved Hide resolved
pkg/antctl/raw/proxy/command_test.go Outdated Show resolved Hide resolved
@KMAnju-2021 KMAnju-2021 force-pushed the ut-tests branch 2 times, most recently from 640978e to 24ec937 Compare May 9, 2023 09:21
pkg/antctl/raw/proxy/command.go Outdated Show resolved Hide resolved
pkg/antctl/raw/proxy/command_test.go Outdated Show resolved Hide resolved
@KMAnju-2021 KMAnju-2021 force-pushed the ut-tests branch 2 times, most recently from dff55be to 290d3ee Compare May 11, 2023 06:27
pkg/antctl/raw/proxy/command.go Outdated Show resolved Hide resolved
pkg/antctl/raw/proxy/command.go Outdated Show resolved Hide resolved
@KMAnju-2021 KMAnju-2021 mentioned this pull request May 12, 2023
37 tasks
@KMAnju-2021 KMAnju-2021 requested a review from antoninbas May 12, 2023 11:29
pkg/antctl/raw/proxy/command_test.go Outdated Show resolved Hide resolved
pkg/antctl/raw/proxy/command_test.go Outdated Show resolved Hide resolved
pkg/antctl/raw/proxy/command_test.go Outdated Show resolved Hide resolved
pkg/antctl/raw/proxy/command_test.go Outdated Show resolved Hide resolved
pkg/antctl/raw/proxy/command_test.go Outdated Show resolved Hide resolved
Comment on lines 35 to 37
if err != nil {
require.NoError(t, err)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just require.NoError(t, err), there is no if statement

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, done.

Signed-off-by: KMAnju-2021 <km074btcse18@igdtuw.ac.in>
Copy link
Contributor

@luolanzone luolanzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor

/test-e2e
/skip-networkpolicy
/skip-conformance

@antoninbas
Copy link
Contributor

/test-e2e

@antoninbas antoninbas merged commit 94fe42d into antrea-io:main May 16, 2023
ceclinux pushed a commit to ceclinux/antrea that referenced this pull request Jun 5, 2023
Signed-off-by: KMAnju-2021 <km074btcse18@igdtuw.ac.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test Issues or PRs related to unit and integration tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants