-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ExternalIP in AntreaProxy #4866
Conversation
5067184
to
18bc9a6
Compare
18bc9a6
to
47c800a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess there may be a misunderstanding between the ExternalIPs field and the ExternalIP type.
f2f668b
to
30680da
Compare
30680da
to
cd5be1f
Compare
1e69e33
to
2d2d6b7
Compare
@hongliangl could you check and improve the unit test code coverage for this patch? thanks. |
Sure |
@hongliangl please help to update the PR summary and commit messages with the necessary information about ExternalIP to help other reviewers to understand this change. |
07a0467
to
0c42fdb
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
4473755
to
897eaee
Compare
bd3c699
to
e21422c
Compare
pkg/agent/openflow/client.go
Outdated
// installs the flow which has a learn action to maintain the LB decision. The group with the groupID must be | ||
// installed before, otherwise the installation will fail. | ||
// externalAddress indicates that whether the Service is externally accessible, like NodePort, LoadBalancer and ExternalIP. | ||
// nested indicates that whether the Service are backed by Endpoints of other Services. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds the Service and other Services are sharing Endpoints, but we actually mean the Service's Endpoint is other Service's ClusterIPs, right?
Nested Service's ClusterIP -> Nested Service's Endpoint (Other Service's ClusterIP) -> Other Service's Endpoint
How about "nested indiciates the whether the Service are backed by Service IPs of other Services"? @jianjuns @hongliangl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is more readable by be backed by Service IPs of other Services
.
isLoad := spec.Header.Dst == true | ||
isMatch := spec.Header.Dst == false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't understand the change, is it fixing an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used to fix the action learn. Previously, action learn to string was wrong.
78c35eb
to
b262e13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cffffcc
to
c9eb9e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds the ability to serve ExternalIP for AntreaProxy, allowing for external client accesses to Services running in Kubernetes. In Kubernetes, an ExternalIP is a feature that allows a Service to be accessed from outside the cluster using a static IP address. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
c9eb9e2
to
993d472
Compare
/test-all |
/test-windows-proxyall-e2e |
/test-windows-proxyall-e2e |
@jianjuns do you have any other comments on this one? |
No. Please merge. |
/skip-conformance which failed on unrelated failure: a deleted service IP happened to be an available external server. |
This PR adds the ability to serve ExternalIP for AntreaProxy, allowing for external client accesses to Services running in Kubernetes. In Kubernetes, an ExternalIP is a feature that allows a Service to be accessed from outside the cluster using a static IP address. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
This PR adds the ability to serve ExternalIP for AntreaProxy, allowing for
external client accesses to Services running in Kubernetes. In Kubernetes, an
ExternalIP is a feature that allows a Service to be accessed from outside the
cluster using a static IP address.
Signed-off-by: Hongliang Liu lhongliang@vmware.com