-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix K8s NP Service Logging #4780
Conversation
Previously used separating |
I see there is a "CnpDenyRegMark" which is loaded for ACNP/ANP drop/deny, maybe we could check it to differentitate if it's a K8s or Antrea policy? The name of the variable needs to be more precise. |
a480bb0
to
ae3d46e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, is it possible to add a test for the scenario which didn't work previously?
Added |
ae3d46e
to
38c125c
Compare
38c125c
to
a015e3a
Compare
228c607
to
3f9e22f
Compare
3f9e22f
to
80a73a0
Compare
/test-all |
test-ipv6-e2e failed:
|
Service for K8s NetworkPolicy is not logging as expected. This solution checks the CnpDenyRegMark in the case of K8s default drop before fetching the conjunction ID match. And also renames Cnp to AP in CnpConjIDField and CnpDenyRegMark. Fixes antrea-io#4765 Signed-off-by: Qiyue Yao <yaoq@vmware.com>
80a73a0
to
7178fe3
Compare
After some investigation, in dual stack case, |
/test-ipv6-e2e |
/test-all |
Service for K8s NetworkPolicy is not logging as expected. This solution checks the CnpDenyRegMark in the case of K8s default drop before fetching the conjunction ID match. And also renames Cnp to AP in CnpConjIDField and CnpDenyRegMark. Fixes antrea-io#4765 Signed-off-by: Qiyue Yao <yaoq@vmware.com>
Service for K8s NetworkPolicy is not logging as expected. This solution checks the CnpDenyRegMark in the case of K8s default drop before fetching the conjunction ID match. And also renames Cnp to AP in CnpConjIDField and CnpDenyRegMark. Fixes antrea-io#4765 Signed-off-by: Qiyue Yao <yaoq@vmware.com>
Service for K8s NetworkPolicy is not logging as expected.
This solution checks
CnpDenyRegMark
to differentiate Antrea native policies and K8s default drops before fetching conjunction ID.And also renames Cnp to AP in CnpConjIDField and CnpDenyRegMark.
Fixes #4765