Avoid duplicate Node Results in Live Traceflow Status #4715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
added
area/ops/traceflow
tnqn
reviewed
Mar 17, 2023
| @@ -34,11 +34,16 @@ import ( | |||
| binding "antrea.io/antrea/pkg/ovs/openflow" | |||
| ) | |||
|
|
|||
| var skipTraceflowUpdateErr = errors.New("Skip Traceflow Update") | |||
There was a problem hiding this comment.
nit: errors.New("skip Traceflow update") to follow the convention that error shouldn't be capitalized first letter unless proper noun, even though it's not appended to any log currently?
| @@ -47,8 +52,7 @@ func (c *Controller) HandlePacketIn(pktIn *ofctrl.PacketIn) error { | |||
| err = retry.RetryOnConflict(retry.DefaultRetry, func() error { | |||
| tf, err := c.traceflowInformer.Lister().Get(oldTf.Name) | |||
| if err != nil { | |||
| klog.Warningf("Get traceflow failed: %+v", err) | |||
| return err | |||
| return fmt.Errorf("Get Traceflow failed: %w", err) | |||
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("Get Traceflow failed: %w", err) | |
| return fmt.Errorf("get Traceflow failed: %w", err) |
| @@ -57,14 +61,13 @@ func (c *Controller) HandlePacketIn(pktIn *ofctrl.PacketIn) error { | |||
| } | |||
| _, err = c.traceflowClient.CrdV1alpha1().Traceflows().UpdateStatus(context.TODO(), update, v1.UpdateOptions{}) | |||
| if err != nil { | |||
| klog.Warningf("Update traceflow failed: %+v", err) | |||
| return err | |||
| return fmt.Errorf("Update Traceflow failed: %w", err) | |||
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("Update Traceflow failed: %w", err) | |
| return fmt.Errorf("update Traceflow failed: %w", err) |
After receiving a Packet In for a live Traceflow, the controller uninstalls the corresponding OVS flows to prevent additional Packet Ins (from different connections which also match the Live Traceflow filters). However, if 2 connections happen within a very short time window (< 1ms in my testbed) and both match the Live Traceflow filters, it is still possible for 2 Packet In messages to be received. To avoid duplicate Node Results in the Live Traceflow Status, we need to ignore all Packet In messages received after the first one. Fixes antrea-io#4714 Signed-off-by: Antonin Bas <abas@vmware.com>
Signed-off-by: Antonin Bas <abas@vmware.com>
antoninbas
force-pushed
the
ignore-additional-packets-in-tf
branch
from
01b1843
to
66473ba
Compare
|
/test-all |
|
@tnqn I addressed your comments. Feel free to include it in Antrea v1.11 or postpone it to the next release, since this is not a serious / core bug. |
I think it's good to be included and there should be no risk. |
jainpulkit22
pushed a commit
to urharshitha/antrea
that referenced
this pull request
Apr 28, 2023
After receiving a Packet In for a live Traceflow, the controller uninstalls the corresponding OVS flows to prevent additional Packet Ins (from different connections which also match the Live Traceflow filters). However, if 2 connections happen within a very short time window (< 1ms in my testbed) and both match the Live Traceflow filters, it is still possible for 2 Packet In messages to be received. To avoid duplicate Node Results in the Live Traceflow Status, we need to ignore all Packet In messages received after the first one. Fixes antrea-io#4714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After receiving a Packet In for a live Traceflow, the controller uninstalls the corresponding OVS flows to prevent additional Packet Ins (from different connections which also match the Live Traceflow filters).
However, if 2 connections happen within a very short time window (< 1ms in my testbed) and both match the Live Traceflow filters, it is still possible for 2 Packet In messages to be received. To avoid duplicate Node Results in the Live Traceflow Status, we need to ignore all Packet In messages received after the first one.
Fixes #4714