-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source ports in Antrea-native policy API #4687
Conversation
406f75f
to
4b9ab83
Compare
Codecov Report
@@ Coverage Diff @@
## main #4687 +/- ##
==========================================
+ Coverage 70.44% 70.48% +0.04%
==========================================
Files 405 380 -25
Lines 60616 59269 -1347
==========================================
- Hits 42698 41775 -923
+ Misses 15031 14663 -368
+ Partials 2887 2831 -56
*This pull request uses carry forward flags. Click here to find out more.
|
30205eb
to
dc8ca81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, some minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should validate srcEndPort can not be specified alone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please squash the commits and add the description to the commit message.
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @GraysonWu please let us if you have other comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In commit message, change "This PR" to "This commit"
148ba47
to
a4cf092
Compare
This commit adds two optional fields, namely 'sourcePort' and 'sourceEndPort' to the NetworkPolicyPort definition of Antrea-native policies. When specified, the policy rule will only match traffic initiated from a specific port (if only sourcePort is provided) or from a specific port range (if both sourcePort and sourceEndPort are provided). Supported protocols are TCP, UDP and SCTP. Signed-off-by: Dyanngg <dingyang@vmware.com>
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@GraysonWu do you have other comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit adds two optional fields, namely 'sourcePort' and 'sourceEndPort' to the NetworkPolicyPort definition of Antrea-native policies. When specified, the policy rule will only match traffic initiated from a specific port (if only sourcePort is provided) or from a specific port range (if both sourcePort and sourceEndPort are provided). Supported protocols are TCP, UDP and SCTP. Signed-off-by: Dyanngg <dingyang@vmware.com>
Fixes #4653
This PR adds two optional fields, namely
sourcePort
andsourceEndPort
to the NetworkPolicyPort definition of Antrea-native policies. When specified, the policy rule will only match traffic initiated from a specific port (if only sourcePort is provided) or from a specific port range (if both sourcePort and sourceEndPort are provided).Supported protocols are TCP, UDP and SCTP.