Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer install Whereabouts CNI to host #4617

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

jianjuns
Copy link
Contributor

@jianjuns jianjuns commented Feb 9, 2023

Whereabouts CNI binary is executed in the antrea-agent container for secondary network IPAM. It needs not to be in the host filesystem.

Signed-off-by: Jianjun Shen shenj@vmware.com

Whereabouts CNI binary is executed in the antrea-agent container for
secondary network IPAM. It needs not to be in the host filesystem.

Signed-off-by: Jianjun Shen <shenj@vmware.com>
@jianjuns jianjuns added the area/component/cni Issues or PRs related to the cni component label Feb 9, 2023
@jianjuns jianjuns marked this pull request as ready for review February 9, 2023 18:14
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #4617 (dc71f8a) into main (6d76ddf) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head dc71f8a differs from pull request most recent head 2b91305. Consider uploading reports for the commit 2b91305 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4617      +/-   ##
==========================================
- Coverage   68.64%   68.53%   -0.11%     
==========================================
  Files         400      400              
  Lines       59450    58271    -1179     
==========================================
- Hits        40809    39937     -872     
+ Misses      15807    15531     -276     
+ Partials     2834     2803      -31     
Flag Coverage Δ *Carryforward flag
e2e-tests 38.31% <ø> (-0.03%) ⬇️
integration-tests 34.46% <ø> (-0.08%) ⬇️ Carriedforward from 2b91305
kind-e2e-tests 40.69% <ø> (+0.22%) ⬆️ Carriedforward from 2b91305
unit-tests 59.76% <ø> (+<0.01%) ⬆️ Carriedforward from 2b91305

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../agent/flowexporter/connections/conntrack_linux.go 70.16% <0.00%> (-15.33%) ⬇️
pkg/agent/controller/egress/egress_controller.go 75.27% <0.00%> (-9.96%) ⬇️
pkg/agent/flowexporter/connections/connections.go 82.22% <0.00%> (-5.56%) ⬇️
...gent/controller/noderoute/node_route_controller.go 62.75% <0.00%> (-5.53%) ⬇️
pkg/agent/wireguard/client_linux.go 77.07% <0.00%> (-4.46%) ⬇️
.../flowexporter/connections/conntrack_connections.go 72.85% <0.00%> (-4.29%) ⬇️
pkg/agent/memberlist/cluster.go 75.38% <0.00%> (-3.95%) ⬇️
...rs/multicluster/member/serviceexport_controller.go 76.33% <0.00%> (-2.80%) ⬇️
pkg/agent/controller/networkpolicy/fqdn.go 75.58% <0.00%> (-2.16%) ⬇️
pkg/agent/util/net_linux.go 29.62% <0.00%> (-1.90%) ⬇️
... and 20 more

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jianjuns
Copy link
Contributor Author

/test-all

@jianjuns
Copy link
Contributor Author

/test-e2e

@jianjuns jianjuns merged commit 97e790b into antrea-io:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/component/cni Issues or PRs related to the cni component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants