Adds unit test for fqdn.go #4582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4582 +/- ##
==========================================
- Coverage 69.58% 69.50% -0.08%
==========================================
Files 400 400
Lines 59122 59122
==========================================
- Hits 41141 41095 -46
- Misses 15175 15219 +44
- Partials 2806 2808 +2
*This pull request uses carry forward flags. Click here to find out more.
|
|
@urharshitha Unit test failed, please check. |
Atish-iaf
reviewed
Jan 24, 2023
Atish-iaf
reviewed
Jan 24, 2023
urharshitha
force-pushed
the
fqdnTesting
branch
3 times, most recently
from
85b6c83 to
3f04497
Compare
Atish-iaf
reviewed
Jan 30, 2023
urharshitha
force-pushed
the
fqdnTesting
branch
from
3f04497 to
8dc583b
Compare
tnqn
reviewed
Feb 3, 2023
| existingDNSCache: map[string]dnsMeta{ | ||
| "test.antrea.io": { | ||
| responseIPs: map[string]net.IP{ | ||
| "IP": net.ParseIP("127.0.0.1"), |
There was a problem hiding this comment.
The key doesn't match the data in real world. It should be the string format of the IP.
And please use more than one IP to cover multiple response IPs case.
urharshitha
force-pushed
the
fqdnTesting
branch
from
8dc583b to
c19dc77
Compare
tnqn
requested changes
Feb 7, 2023
| f.dnsEntryCache = tc.existingDNSCache | ||
| } | ||
| gotOutput := f.getIPsForFQDNSelectors(tc.fqdns) | ||
| assert.Equal(t, tc.expectedMatchedIPs, gotOutput) |
There was a problem hiding this comment.
Use ElementsMatch to avoid order mismatch.
The unit test failed.
Signed-off-by: Harshitha U R <harshithaur1611@gmail.com>
urharshitha
force-pushed
the
fqdnTesting
branch
from
c19dc77 to
e6bf9f7
Compare
tnqn
approved these changes
Feb 8, 2023
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the unit test for pkg/agent/controller/networkpolicy/fqdn.go
for #4142
Signed-off-by: Harshitha U R harshithaur1611@gmail.com