Automated cherry pick of #4491: Make memberlist cluster rejoin dead nodes periodically #4527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xliuxu
added
the
kind/cherry-pick
Codecov Report
@@ Coverage Diff @@
## release-1.9 #4527 +/- ##
===============================================
+ Coverage 64.39% 64.57% +0.18%
===============================================
Files 393 393
Lines 55570 55600 +30
===============================================
+ Hits 35783 35904 +121
+ Misses 17178 17092 -86
+ Partials 2609 2604 -5
|
|
/test-all |
|
@xliuxu The upgrade test still failed after image is updated. It may be because the PR is not rebased. Could you rebase it and the other one? |
The patch periodically rejoins Nodes that were removed from the member list by memberlist because they were unreachable for more than 15 seconds (the GossipToTheDeadTime we are using). Without it, once there is a network downtime lasting more than 15 seconds, the agent wouldn't try to reach any other Node and would think it's the only alive Node until it's restarted. Signed-off-by: Quan Tian <qtian@vmware.com>
xliuxu
force-pushed
the
automated-cherry-pick-of-#4491-upstream-release-1.9
branch
from
ea17a54
to
015aaec
Compare
Rebased on release-1.9. |
|
/skip-all |
tnqn
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #4491 on release-1.9.
#4491: Make memberlist cluster rejoin dead nodes periodically
For details on the cherry pick process, see the cherry pick requests page.