-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import auth to support different platforms #4494
Conversation
Antctl failed to talk with GCP cluster and it shows: `Error: no Auth Provider found for name "gcp"`. According to the example of client-go, we need to import auth package to support different public platform's authentication. Signed-off-by: Lan Luo <luola@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #4494 +/- ##
==========================================
- Coverage 67.87% 66.82% -1.05%
==========================================
Files 402 404 +2
Lines 57284 60366 +3082
==========================================
+ Hits 38879 40339 +1460
- Misses 15707 17329 +1622
Partials 2698 2698
|
@jianjuns @tnqn @antoninbas could you take a look at this tiny PR? thanks. |
/test-all |
@luolanzone do you want to backport this? |
@antoninbas I think it's better to backport this, any suggestion? or which version we should backport to? |
It's up to you. Backporting it to v1.10 may be a good idea. |
Antctl failed to talk with GCP cluster and it shows:
Error: no Auth Provider found for name "gcp"
. According to the example of client-go, we need to import auth package to support different public platform's authentication.Here is the sample code:
https://github.com/kubernetes/client-go/blob/master/examples/out-of-cluster-client-configuration/main.go#L33-L40
Signed-off-by: Lan Luo luola@vmware.com