Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #4412: Fix ClusterInfo type ResourceExport recreation bug #4442

Conversation

luolanzone
Copy link
Contributor

Cherry pick of #4412 on release-1.9.

#4412: Fix ClusterInfo type ResourceExport recreation bug

For details on the cherry pick process, see the cherry pick requests page.

After Gateway HA is enabled, the ClusterInfo type of ResourceExport
will be recreated when the active Gateway is changed. But there is a case
that a new ClusterInfo of ResourceExport creation may fail when the
leader controller process is slow and existing ResourceExport is not
deleted in time.
Fix the issue through retry when the existing ResourceExport's DeletionTimestamp
is not zero.

Signed-off-by: Lan Luo <luola@vmware.com>
@luolanzone luolanzone added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Dec 6, 2022
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #4442 (77ad680) into release-1.9 (9946974) will decrease coverage by 1.71%.
The diff coverage is 40.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.9    #4442      +/-   ##
===============================================
- Coverage        66.57%   64.86%   -1.72%     
===============================================
  Files              369      405      +36     
  Lines            53290    55607    +2317     
===============================================
+ Hits             35478    36069     +591     
- Misses           15240    16931    +1691     
- Partials          2572     2607      +35     
Flag Coverage Δ
e2e-tests 61.44% <40.00%> (?)
integration-tests 34.63% <0.00%> (+<0.01%) ⬆️
kind-e2e-tests 48.24% <ø> (-0.81%) ⬇️
unit-tests 48.23% <40.00%> (-1.32%) ⬇️
Impacted Files Coverage Δ
...ter/controllers/multicluster/gateway_controller.go 84.09% <40.00%> (+20.85%) ⬆️
pkg/ovs/ovsctl/ovsctl_others.go 53.84% <0.00%> (-25.65%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam.go 51.08% <0.00%> (-22.95%) ⬇️
pkg/agent/flowexporter/exporter/certificate.go 27.77% <0.00%> (-22.23%) ⬇️
pkg/ipfix/ipfix_process.go 81.25% <0.00%> (-18.75%) ⬇️
...nt/apiserver/handlers/serviceexternalip/handler.go 37.03% <0.00%> (-14.82%) ⬇️
pkg/agent/controller/networkpolicy/packetin.go 61.48% <0.00%> (-11.49%) ⬇️
pkg/agent/flowexporter/exporter/exporter.go 71.53% <0.00%> (-10.15%) ⬇️
pkg/controller/externalippool/controller.go 86.16% <0.00%> (-6.25%) ⬇️
pkg/controller/networkpolicy/store/addressgroup.go 88.37% <0.00%> (-3.49%) ⬇️
... and 82 more

@jianjuns
Copy link
Contributor

jianjuns commented Dec 6, 2022

@luolanzone : could you check if UBI build can be fixed or not?

@luolanzone
Copy link
Contributor Author

@luolanzone : could you check if UBI build can be fixed or not?

sure, I will check.

@luolanzone
Copy link
Contributor Author

@jianjuns I think we need another cherry-pick for the PR #4389, this fixed the UBI image issue.

@jianjuns jianjuns merged commit abafaba into antrea-io:release-1.9 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants