Add unit tests for pkg/agent/controller/traceflow/traceflow_controller.go #4409
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4409 +/- ##
=======================================
Coverage 62.00% 62.00%
=======================================
Files 392 392
Lines 56732 56732
=======================================
Hits 35179 35179
Misses 18930 18930
Partials 2623 2623
|
| ovsClient *ovsconfigtest.MockOVSBridgeClient | ||
| } | ||
|
|
||
| func newFakeController(t *testing.T, initObjects []runtime.Object, networkConfig *config.NetworkConfig, nodeConfig *config.NodeConfig) *fakeController { |
There was a problem hiding this comment.
prefer function name and relate to traceflow like newFakeTraceflowController
| } | ||
| ) | ||
|
|
||
| type fakeController struct { |
There was a problem hiding this comment.
use specific names for structure like fakeTraceflowController
|
|
||
| var ( | ||
| pod1IP = "1.1.1.1" | ||
| pod2IP = "2.2.2.2" |
There was a problem hiding this comment.
same as above, if string type user pod2IPStr
There was a problem hiding this comment.
changed to pod2IPv4, string type can be identified by var type also.
| ) | ||
|
|
||
| var ( | ||
| pod1IP = "1.1.1.1" |
There was a problem hiding this comment.
Prefer using specific types like pod1IPv4 for ipv4
Atish-iaf
force-pushed
the
UT/pkg/agent/traceflow/controller
branch
from
5f94001 to
ae289e2
Compare
Atish-iaf
force-pushed
the
UT/pkg/agent/traceflow/controller
branch
from
ae289e2 to
bcebed0
Compare
|
|
||
| tfc.enqueueTraceflow(tc.tf) | ||
|
|
||
| got := tfc.processTraceflowItem() |
There was a problem hiding this comment.
processedTraceflow := tfc.processTraceflowItem()
| tfc := newFakeTraceflowController(t, []runtime.Object{tf}, nil, nil, nil) | ||
| defer tfc.mockController.Finish() | ||
|
|
||
| gotTf, err := tfc.errorTraceflowCRD(tf, reason) |
There was a problem hiding this comment.
instead of gotTf, you can use processedTraceflow, or tfReceived, just a suggestion.
|
@tnqn Can you please review this PR ? |
Atish-iaf
force-pushed
the
UT/pkg/agent/traceflow/controller
branch
2 times, most recently
from
e78ab6f to
ba2585d
Compare
Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
Atish-iaf
force-pushed
the
UT/pkg/agent/traceflow/controller
branch
from
ba2585d to
0163404
Compare
|
/skip-all |
|
@Atish-iaf please use more meaningful commit title for future PRs, just "Add unit tests" is not helpful to figure out what the commit is created for among so many commits for unit tests. |
…r.go (antrea-io#4409) Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
Add unit tests
For #4142
Signed-off-by: Kumar Atish atish.iaf@gmail.com