Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for graphviz #4263

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Add unit test for graphviz #4263

merged 1 commit into from
Sep 30, 2022

Conversation

luolanzone
Copy link
Contributor

@luolanzone luolanzone commented Sep 30, 2022

Part of #4142 (Improve unit test coverage)
Signed-off-by: Lan Luo luola@vmware.com

Signed-off-by: Lan Luo <luola@vmware.com>
@luolanzone luolanzone mentioned this pull request Sep 30, 2022
37 tasks
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #4263 (63b2f7f) into main (e7486d5) will increase coverage by 0.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4263      +/-   ##
==========================================
+ Coverage   62.24%   62.79%   +0.55%     
==========================================
  Files         385      385              
  Lines       54513    54513              
==========================================
+ Hits        33929    34232     +303     
+ Misses      18105    17745     -360     
- Partials     2479     2536      +57     
Flag Coverage Δ
integration-tests 35.00% <ø> (-0.14%) ⬇️
kind-e2e-tests 48.99% <ø> (+0.84%) ⬆️
unit-tests 44.23% <ø> (+0.39%) ⬆️
Impacted Files Coverage Δ
pkg/agent/cniserver/ipam/ipam_service.go 76.40% <0.00%> (-12.36%) ⬇️
...ntrollers/multicluster/serviceexport_controller.go 76.62% <0.00%> (-2.86%) ⬇️
...catesigningrequest/ipsec_csr_signing_controller.go 61.65% <0.00%> (-2.46%) ⬇️
...trollers/multicluster/resourceexport_controller.go 77.86% <0.00%> (-2.19%) ⬇️
pkg/agent/openflow/multicluster.go 44.85% <0.00%> (-1.87%) ⬇️
...lticluster/commonarea/resourceimport_controller.go 79.18% <0.00%> (-1.86%) ⬇️
pkg/agent/proxy/proxier.go 69.13% <0.00%> (-1.55%) ⬇️
pkg/controller/ipam/antrea_ipam_controller.go 75.25% <0.00%> (-1.01%) ⬇️
pkg/agent/util/net.go 53.55% <0.00%> (-0.75%) ⬇️
pkg/ovs/openflow/ofctrl_bridge.go 77.26% <0.00%> (-0.58%) ⬇️
... and 22 more

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Sep 30, 2022

/skip-all

@tnqn tnqn merged commit d9ea6bf into antrea-io:main Sep 30, 2022
heanlan pushed a commit to heanlan/antrea that referenced this pull request Mar 29, 2023
Signed-off-by: Lan Luo <luola@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants