Improve unit test of certificate package #4204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luolanzone
commented
Sep 6, 2022
| @@ -177,7 +174,7 @@ func (c *CACertController) syncConversionWebhooks(caCert []byte) error { | |||
| } | |||
| if updated { | |||
| if _, err := c.apiExtensionClient.ApiextensionsV1().CustomResourceDefinitions().Update(context.TODO(), crdDef, metav1.UpdateOptions{}); err != nil { | |||
| return err | |||
| return fmt.Errorf("error updating antrea CA cert of CustomResourceDefinition %s: %v", name, err) | |||
There was a problem hiding this comment.
Keep the error format the same as other sync functions.
| @@ -44,8 +43,6 @@ const ( | |||
| // CACertController is responsible for taking the CA certificate from the | |||
| // caContentProvider and publishing it to the ConfigMap and the APIServices. | |||
| type CACertController struct { | |||
| mutex sync.RWMutex | |||
There was a problem hiding this comment.
This is unused field.
Codecov Report
@@ Coverage Diff @@
## main #4204 +/- ##
==========================================
+ Coverage 58.30% 60.83% +2.53%
==========================================
Files 384 384
Lines 54376 54375 -1
==========================================
+ Hits 31702 33081 +1379
+ Misses 20257 18873 -1384
- Partials 2417 2421 +4
|
luolanzone
force-pushed
the
add-cert-unit-tests
branch
3 times, most recently
from
033b832 to
17d2d9e
Compare
tnqn
reviewed
Sep 8, 2022
luolanzone
force-pushed
the
add-cert-unit-tests
branch
from
17d2d9e to
56a6814
Compare
tnqn
reviewed
Sep 8, 2022
Comment on lines
312
to
320
| existingWebhook *admissionregistrationv1.MutatingWebhookConfiguration | ||
| existingOptionalWebhook *admissionregistrationv1.MutatingWebhookConfiguration |
There was a problem hiding this comment.
Is it simpler to just use an existingWebhook slice, which represents the objects that will be added to storage before testing?
There was a problem hiding this comment.
Yeah, refined, thanks.
There was a problem hiding this comment.
Ah, misunderstood the comments, merge them into a slice. thanks.
luolanzone
force-pushed
the
add-cert-unit-tests
branch
from
56a6814 to
dcb293d
Compare
Signed-off-by: Lan Luo <luola@vmware.com>
luolanzone
force-pushed
the
add-cert-unit-tests
branch
from
dcb293d to
5c48b55
Compare
|
/skip-all |
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
Signed-off-by: Lan Luo <luola@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #4142
Signed-off-by: Lan Luo luola@vmware.com