Add unit test for pkg exporter #4195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4195 +/- ##
==========================================
+ Coverage 58.30% 61.12% +2.82%
==========================================
Files 384 384
Lines 54376 54379 +3
==========================================
+ Hits 31702 33240 +1538
+ Misses 20257 18702 -1555
- Partials 2417 2437 +20
|
yuntanghsu
force-pushed
the
ut_flowaggregator_exporter
branch
from
f179b8a to
994e366
Compare
antoninbas
reviewed
Sep 6, 2022
Comment on lines
+89
to
+94
| // PrepareClickHouseConnection is used for unit testing | ||
| var ( | ||
| PrepareClickHouseConnection = func(input ClickHouseInput) (string, *sql.DB, error) { | ||
| return PrepareConnection(input) | ||
| } | ||
| ) |
There was a problem hiding this comment.
it's a bit clunky that this needs to be an exported variable, but I understand that there isn't any obvious alternative here...
Signed-off-by: Yun-Tang Hsu <hsuy@vmware.com>
yuntanghsu
force-pushed
the
ut_flowaggregator_exporter
branch
from
994e366 to
8610ae4
Compare
antoninbas
approved these changes
Sep 7, 2022
|
/test-networkpolicy |
heanlan
approved these changes
Sep 8, 2022
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
For antrea-io#4142 Signed-off-by: Yun-Tang Hsu <hsuy@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit test for pkg exporter under flowaggregator
For #4142
Signed-off-by: Yun-Tang Hsu hsuy@vmware.com