Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multi-cluster unit test #4158

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Conversation

luolanzone
Copy link
Contributor

@luolanzone luolanzone commented Aug 29, 2022

Add more unit tests for multi-cluster and remove some dead codes.

For #4142
Signed-off-by: Lan Luo luola@vmware.com

Add more unit tests for multi-cluster and remove some dead codes.

Signed-off-by: Lan Luo <luola@vmware.com>
@luolanzone luolanzone added the area/multi-cluster Issues or PRs related to multi cluster. label Aug 29, 2022
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

2 similar comments
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #4158 (8163b7e) into main (3696543) will increase coverage by 0.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4158      +/-   ##
==========================================
+ Coverage   65.92%   66.84%   +0.91%     
==========================================
  Files         304      315      +11     
  Lines       46626    46655      +29     
==========================================
+ Hits        30737    31185     +448     
+ Misses      13487    13045     -442     
- Partials     2402     2425      +23     
Flag Coverage Δ
e2e-tests 58.68% <ø> (?)
integration-tests 34.94% <ø> (+<0.01%) ⬆️
kind-e2e-tests 49.46% <ø> (+0.41%) ⬆️
unit-tests 45.05% <ø> (+0.09%) ⬆️
Impacted Files Coverage Δ
...icluster/controllers/multicluster/common/helper.go 88.23% <ø> (+30.23%) ⬆️
pkg/ovs/ovsctl/ofctl.go 46.57% <0.00%> (-5.48%) ⬇️
pkg/agent/controller/networkpolicy/reject.go 77.50% <0.00%> (-3.50%) ⬇️
pkg/agent/route/route_linux.go 50.21% <0.00%> (-2.98%) ⬇️
pkg/agent/openflow/multicluster.go 44.85% <0.00%> (-1.87%) ⬇️
pkg/controller/externalippool/controller.go 83.03% <0.00%> (-1.79%) ⬇️
pkg/flowaggregator/flowaggregator.go 68.31% <0.00%> (-1.74%) ⬇️
pkg/agent/util/iptables/iptables.go 45.07% <0.00%> (-1.56%) ⬇️
pkg/util/k8s/node.go 80.90% <0.00%> (-0.91%) ⬇️
pkg/agent/openflow/network_policy.go 78.49% <0.00%> (-0.87%) ⬇️
... and 48 more

@luolanzone luolanzone requested a review from jianjuns August 30, 2022 09:19
@jianjuns
Copy link
Contributor

/skip-all

@jianjuns jianjuns merged commit 3714619 into antrea-io:main Aug 30, 2022
@luolanzone luolanzone deleted the improve-mc-test branch August 31, 2022 02:48
heanlan pushed a commit to heanlan/antrea that referenced this pull request Mar 29, 2023
Add more unit tests for multi-cluster and remove some dead code.

Signed-off-by: Lan Luo <luola@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/multi-cluster Issues or PRs related to multi cluster.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants