Add unit test for egress group store #4151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4151 +/- ##
==========================================
+ Coverage 65.08% 66.19% +1.10%
==========================================
Files 303 304 +1
Lines 46561 46625 +64
==========================================
+ Hits 30304 30862 +558
+ Misses 13903 13366 -537
- Partials 2354 2397 +43
|
tnqn
reviewed
Aug 25, 2022
| w, err := store.Watch(context.Background(), "", labels.Everything(), tc.fieldSelector) | ||
| if err != nil { | ||
| t.Fatalf("Failed to watch object: %v", err) | ||
| } |
There was a problem hiding this comment.
it should stop the watcher after the test finishes.
There was a problem hiding this comment.
Updated. BTW. Does it need to change this test function in this PR? same structure as TestWatchNetworkPolicyEvent
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
|
/skip-all |
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit test for egress group store
For #4142
Signed-off-by: Wenqi Qiu wenqiq@vmware.com