Make disabling TX checksum offload configurable #3832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnqn
added
the
action/release-note
5 tasks
Codecov Report
@@ Coverage Diff @@
## main #3832 +/- ##
===========================================
- Coverage 62.18% 46.10% -16.09%
===========================================
Files 281 247 -34
Lines 40091 35913 -4178
===========================================
- Hits 24931 16556 -8375
- Misses 13190 17720 +4530
+ Partials 1970 1637 -333
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-all |
jianjuns
reviewed
May 26, 2022
| @@ -48,7 +48,7 @@ type ifConfigurator struct { | |||
| epCache *sync.Map | |||
| } | |||
|
|
|||
| func newInterfaceConfigurator(ovsDatapathType ovsconfig.OVSDatapathType, isOvsHardwareOffloadEnabled bool) (*ifConfigurator, error) { | |||
There was a problem hiding this comment.
Add a comment saying disableTXChecksumOffload is ignored on Windows?
| @@ -170,6 +170,10 @@ data: | |||
| # `trafficEncapMode` is `noEncap`, and `noSNAT` is true. | |||
| enableBridgingMode: false | |||
|
|
|||
| # Disable TX checksum offloading for container network interfaces. It's supposed to be set to true when the | |||
| # datapath doesn't support TX checksum offloading, which causes packets to be dropped due to bad checksum. | |||
| disableTXChecksumOffload: false | |||
There was a problem hiding this comment.
We should say it is on Linux only?
Yes. I remember it's also the case of Snort. I saw this issue in several places where packets are passed to userspace and sent back to kernel for transmission. Not sure if it's specific to AF_PACKET, I will try other capture methods. |
Add a configuration parameter `disableTXChecksumOffload` for Antrea Agent to support cases in which the datapath doesn't support TX checksum offloading, which causes packets to be dropped due to bad checksum. Signed-off-by: Quan Tian <qtian@vmware.com>
jianjuns
approved these changes
May 26, 2022
|
/test-all |
antoninbas
approved these changes
May 26, 2022
|
Sure @jianjuns @antoninbas, I will explore better solutions. |
hongliangl
added a commit
to hongliangl/antrea
that referenced
this pull request
Jun 30, 2022
This is a supplement to PR antrea-io#3832. When `disableTXChecksumOffload` is true, TX checksum offload should be also disabled, otherwise for the cases in which the datapath doesn't support TX checksum offloading, packets received on Antrea gateway could be dropped due to bad checksum. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl
added a commit
to hongliangl/antrea
that referenced
this pull request
Jul 1, 2022
This is a supplement to PR antrea-io#3832. When `disableTXChecksumOffload` is true, TX checksum offload of Antrea gateway should be also disabled, otherwise for the cases in which the datapath doesn't support TX checksum offloading, packets sent from Antrea gateway could be dropped due to bad checksum. Note that, when changing `disableTXChecksumOffload` from true back to false, TX checksum offload of Antrea gateway will not be enabled automatically, and TX checksum offload can be enabled manually with ethtool. Another way is to remove Antrea gateway interface before updating `disableTXChecksumOffload`. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl
added a commit
to hongliangl/antrea
that referenced
this pull request
Sep 27, 2022
This is a supplement to PR antrea-io#3832. When `disableTXChecksumOffload` is true, TX checksum offload of Antrea gateway should be also disabled, otherwise for the cases in which the datapath doesn't support TX checksum offloading, packets sent from Antrea gateway could be dropped due to bad checksum. Note that, when changing `disableTXChecksumOffload` from true back to false, TX checksum offload of Antrea gateway will not be enabled automatically, and TX checksum offload can be enabled manually with ethtool. Another way is to remove Antrea gateway interface before updating `disableTXChecksumOffload`. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration parameter
disableTXChecksumOffloadfor Antrea Agent to support cases in which the datapath doesn't support TX checksum offloading, which causes packets to be dropped due to bad checksum.Signed-off-by: Quan Tian qtian@vmware.com
This is required when using TrafficControl Redirect action with threat detection engines' certain packet capture methods, e.g. Suricata AF_PACKET, with which skb csum state is messed up after it's processed by engines' userspace, leading to packet drop on destination.