Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dual-stack support for Vagrant-based test cluster #3158

Conversation

antoninbas
Copy link
Contributor

Use same private network for IPv4 and IPv6 by using a custom netplan
instead of relying on Vagrant to configure K8s networking. This enables
us to meet the condition that both the Node's IPv4 and IPv6 addresses be
assigned to the same interface (required by Antrea).

Fixes #3157

Signed-off-by: Antonin Bas abas@vmware.com

Use same private network for IPv4 and IPv6 by using a custom netplan
instead of relying on Vagrant to configure K8s networking. This enables
us to meet the condition that both the Node's IPv4 and IPv6 addresses be
assigned to the same interface (required by Antrea).

Fixes antrea-io#3157

Signed-off-by: Antonin Bas <abas@vmware.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2021

Codecov Report

Merging #3158 (26f86cd) into main (ebeb2d4) will decrease coverage by 1.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3158      +/-   ##
==========================================
- Coverage   60.74%   59.68%   -1.07%     
==========================================
  Files         295      295              
  Lines       24907    24907              
==========================================
- Hits        15130    14865     -265     
- Misses       8118     8414     +296     
+ Partials     1659     1628      -31     
Flag Coverage Δ
kind-e2e-tests 46.51% <ø> (-1.11%) ⬇️
unit-tests 40.34% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/util/net.go 16.32% <0.00%> (-22.45%) ⬇️
pkg/agent/route/route_linux.go 26.88% <0.00%> (-19.80%) ⬇️
pkg/agent/util/ipset/ipset.go 61.53% <0.00%> (-7.70%) ⬇️
pkg/agent/openflow/pipeline.go 67.60% <0.00%> (-6.30%) ⬇️
pkg/util/k8s/client.go 46.34% <0.00%> (-4.88%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam_controller.go 61.53% <0.00%> (-3.85%) ⬇️
pkg/agent/proxy/types/groupcounter.go 90.56% <0.00%> (-3.78%) ⬇️
pkg/agent/proxy/proxier.go 57.43% <0.00%> (-2.78%) ⬇️
pkg/ovs/openflow/ofctrl_action.go 67.91% <0.00%> (-1.67%) ⬇️
...kg/agent/flowexporter/connections/conntrack_ovs.go 76.36% <0.00%> (-1.22%) ⬇️
... and 8 more

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor Author

/skip-all

merging this as it doesn't need CI

@antoninbas antoninbas merged commit 089a008 into antrea-io:main Dec 23, 2021
@antoninbas antoninbas deleted the fix-dual-stack-support-for-vagrant-based-test-cluster branch December 23, 2021 18:48
bangqipropel pushed a commit to bangqipropel/antrea that referenced this pull request Jan 19, 2022
Use same private network for IPv4 and IPv6 by using a custom netplan
instead of relying on Vagrant to configure K8s networking. This enables
us to meet the condition that both the Node's IPv4 and IPv6 addresses be
assigned to the same interface (required by Antrea).

Fixes antrea-io#3157

Signed-off-by: Antonin Bas <abas@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dual-stack case is broken for Vagrant-based test cluster
3 participants