-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix init node transport interface bug #2670
Conversation
1.Fix adding node routes crash bug, which caused by uninitialized DualStackIPs param. 2.Fix ipv4 address and ipv6 address confused bug and return the first ipv4 and ipv6 ips for transport interface. Signed-off-by: Wu zhengdong <zhengdong.wu@transwarp.io>
1.Fix adding node routes crash bug, which caused by uninitialized DualStackIPs param. 2.Fix ipv4 address and ipv6 address confused bug and return the first ipv4 and ipv6 ips for transport interface. Signed-off-by: Wu zhengdong <zhengdong.wu@transwarp.io>
Codecov Report
@@ Coverage Diff @@
## main #2670 +/- ##
==========================================
+ Coverage 60.66% 65.66% +4.99%
==========================================
Files 285 285
Lines 22997 26351 +3354
==========================================
+ Hits 13951 17303 +3352
+ Misses 7545 7433 -112
- Partials 1501 1615 +114
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1.Fix adding node routes crash bug, which caused by uninitialized DualStackIPs param. 2.Fix ipv4 address and ipv6 address confused bug and return the first ipv4 and ipv6 ips for transport interface. Signed-off-by: Wu zhengdong <zhengdong.wu@transwarp.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jexf thanks for catching the issues before it's released!
Apparently the corresponding change #2436 is lack of unit tests to cover the two functions.
I will first merge this to fix the bug. @Jexf It would be great if you could have another PR to help fix the unit tests for the two functions so the error won't happen again. Please let me know if you feel ok to do it, or I would request @lzhecheng to follow up.
/test-all |
Thank you for reminding me, I will add unit tests for the two functions in another PR. |
/test-windows-e2e /test-windows-networkpolicy |
1.Fix adding node routes crash bug, which caused by uninitialized DualStackIPs param. 2.Fix ipv4 address and ipv6 address confused bug and return the first ipv4 and ipv6 ips for transport interface. Signed-off-by: Wu zhengdong <zhengdong.wu@transwarp.io>
1.Fix adding node routes crash bug, which caused by uninitialized DualStackIPs param. 2.Fix ipv4 address and ipv6 address confused bug and return the first ipv4 and ipv6 ips for transport interface. Signed-off-by: Wu zhengdong <zhengdong.wu@transwarp.io> Co-authored-by: Wu zhengdong <zhengdong.wu@transwarp.io>
1.Fix adding node routes crash bug, which caused by uninitialized DualStackIPs param.
2.Fix ipv4 address and ipv6 address confused bug and return the first ipv4 and ipv6 ips for transport interface.
Fixes #2665
Signed-off-by: Wu zhengdong zhengdong.wu@transwarp.io