Adding documentation for FQDN based filtering in Antrea Network Policy #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
reviewed
Aug 24, 2021
|
@madhukark please fix the typo in the commit message and PR title (s/documentaion/documentation). Please also reference the issue you are addressing by adding |
madhukark
changed the title
abhiraut
reviewed
Aug 24, 2021
|
@madhukark your PR is showing a change that has already been merged into main. Please rebase your PR. |
Fixes antrea-io#2626 Signed-off-by: Madhukar Krishnarao <krishnaraom@vmware.com>
madhukark
force-pushed
the
add-fqdn-doc
branch
from
ac252dd
to
a8aefd5
Compare
antoninbas
reviewed
Aug 25, 2021
There was a problem hiding this comment.
a couple of nits, otherwise LGTM
@abhiraut any more comments from you?
abhiraut
reviewed
Aug 25, 2021
Fixes antrea-io#2626 Signed-off-by: Madhukar Krishnarao <krishnaraom@vmware.com>
abhiraut
approved these changes
Aug 25, 2021
antoninbas
approved these changes
Aug 25, 2021
Codecov Report
@@ Coverage Diff @@
## main #2634 +/- ##
===========================================
- Coverage 59.54% 41.40% -18.14%
===========================================
Files 287 160 -127
Lines 23135 19402 -3733
===========================================
- Hits 13776 8034 -5742
- Misses 7937 10637 +2700
+ Partials 1422 731 -691
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Madhukar Krishnarao krishnaraom@vmware.com