-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding documentation for FQDN based filtering in Antrea Network Policy #2634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this. Adding some more folks for review.
@madhukark please fix the typo in the commit message and PR title (s/documentaion/documentation). Please also reference the issue you are addressing by adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo - comment inlline
@madhukark your PR is showing a change that has already been merged into main. Please rebase your PR. |
Fixes antrea-io#2626 Signed-off-by: Madhukar Krishnarao <krishnaraom@vmware.com>
ac252dd
to
a8aefd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of nits, otherwise LGTM
@abhiraut any more comments from you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.. no additional comments.. thanks for addressing them!
Fixes antrea-io#2626 Signed-off-by: Madhukar Krishnarao <krishnaraom@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #2634 +/- ##
===========================================
- Coverage 59.54% 41.40% -18.14%
===========================================
Files 287 160 -127
Lines 23135 19402 -3733
===========================================
- Hits 13776 8034 -5742
- Misses 7937 10637 +2700
+ Partials 1422 731 -691
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Madhukar Krishnarao krishnaraom@vmware.com