Update AllowToCoreDNS rule to permit udp on port 53 #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Rieger <brieger@vmware.com>
antoninbas
reviewed
Aug 16, 2021
Signed-off-by: Brian Rieger <brieger@vmware.com>
|
@antoninbas done I didn't see the 2nd one initially. |
Codecov Report
@@ Coverage Diff @@
## main #2605 +/- ##
==========================================
- Coverage 42.05% 42.04% -0.02%
==========================================
Files 153 153
Lines 18565 18565
==========================================
- Hits 7807 7805 -2
+ Misses 10060 10057 -3
- Partials 698 703 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/skip-all |
tnqn
added
the
kind/documentation
zyiou
pushed a commit
to zyiou/antrea
that referenced
this pull request
Aug 17, 2021
Signed-off-by: Brian Rieger <brieger@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNS requests are of both UDP and TCP. When testing the AllowToCoreDNS Rule I was running into issues with wget and nslookup not resolving from within a pod by adding in a second port and protocol combo this was resolved. This update should make for it clearer how to expose dns to end users while the old example technically still worked it would not permit all dns traffic.
Signed-off-by: Brian Rieger brieger@vmware.com