Support --sort-by flag for "antctl get networkpolicy" for Agent #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this change, the flag was only supported in "Controller mode". This was a bit confusing when running "antctl get networkpolicy" from the Agent Pod, because 1) the option shows in the examples from the help message, and 2) the documentation doesn't make it clear that this flag only works in "Controller mode". Rather than update the documentation and add complexity in the help message, I am adding support for that flag in "Agent mode". There doesn't seem to be any reason not to. Signed-off-by: Antonin Bas <abas@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #2604 +/- ##
===========================================
+ Coverage 42.05% 60.40% +18.35%
===========================================
Files 153 282 +129
Lines 18565 22412 +3847
===========================================
+ Hits 7807 13538 +5731
+ Misses 10060 7451 -2609
- Partials 698 1423 +725
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-all |
antoninbas
deleted the
support-sort-by-flag-for-agented-antctl-get-networkpolicy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this change, the flag was only supported in "Controller
mode". This was a bit confusing when running "antctl get networkpolicy"
from the Agent Pod, because 1) the option shows in the examples from the
help message, and 2) the documentation doesn't make it clear that this
flag only works in "Controller mode".
Rather than update the documentation and add complexity in the help
message, I am adding support for that flag in "Agent mode". There
doesn't seem to be any reason not to.
Signed-off-by: Antonin Bas abas@vmware.com