Update Antrea-native policy doc for Namespace labels #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add note regarding how to use the Namespace by Name feature in K8s and Antrea-native network policies depending on the K8s version. Signed-off-by: abhiraut <rauta@vmware.com>
abhiraut
added
the
kind/documentation
antoninbas
reviewed
Aug 12, 2021
docs/antrea-network-policy.md
Outdated
|
|
||
| ### K8s clusters with version 1.21 and above | ||
|
|
||
| Starting with K8s v1.21, all Namespaces will be labeled with `kubernetes.io/metadata.name: <namespaceName>` [label](https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/#automatic-labelling) |
There was a problem hiding this comment.
Suggested change
| Starting with K8s v1.21, all Namespaces will be labeled with `kubernetes.io/metadata.name: <namespaceName>` [label](https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/#automatic-labelling) | |
| Starting with K8s v1.21, all Namespaces are labeled with the `kubernetes.io/metadata.name: <namespaceName>` [label] |
docs/antrea-network-policy.md
Outdated
| ### K8s clusters with version 1.21 and above | ||
|
|
||
| Starting with K8s v1.21, all Namespaces will be labeled with `kubernetes.io/metadata.name: <namespaceName>` [label](https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/#automatic-labelling) | ||
| provided that the `NamespaceDefaultLabelName` feature gate is enabled. K8s NetworkPolicy |
There was a problem hiding this comment.
should emphasize that the feature gate is enabled by default in v1.21, this was never an alpha feature, it went straight to Beta
in v1.22, it is GA and cannot even be disabled anymore
Signed-off-by: abhiraut <rauta@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #2596 +/- ##
===========================================
- Coverage 60.10% 42.18% -17.92%
===========================================
Files 282 153 -129
Lines 22337 18491 -3846
===========================================
- Hits 13426 7801 -5625
- Misses 7491 9986 +2495
+ Partials 1420 704 -716
Flags with carried forward coverage won't be shown. Click here to find out more.
|
antoninbas
approved these changes
Aug 16, 2021
|
/skip-all |
zyiou
pushed a commit
to zyiou/antrea
that referenced
this pull request
Aug 17, 2021
* Update Antrea-native policy doc for Namespace labels Add note regarding how to use the Namespace by Name feature in K8s and Antrea-native network policies depending on the K8s version. Signed-off-by: abhiraut <rauta@vmware.com> * Add note regarding feature gate deletion Signed-off-by: abhiraut <rauta@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add note regarding how to use the Namespace by Name feature in K8s and Antrea-native network policies depending on the
K8s version.
Signed-off-by: abhiraut rauta@vmware.com