-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ClusterGroup singular name #2484
Conversation
This PR updates the singular name of the ClusterGroup CRD from "group" to "clustergroup". After this update, the "kubectl get group" command will not return any ClusterGroups. However, the most common way and the documented way to return ClusterGroups using kubectl have been to use "kubectl get cg" or "kubectl get clustergroups". Signed-off-by: abhiraut <rauta@vmware.com>
i ack that this PR may be rejected. Confirming whether aliasing is the only use for "singular" field. Even though the documented way and most used way is to use "clustergroups" or "cg" to return ClusterGroups, astute users of CRDs may be using "group" to return ClusterGroups. This is bad, but how bad? Alternative is to continue with this term and use a new term for Namespaced Group CRD |
Codecov Report
@@ Coverage Diff @@
## main #2484 +/- ##
===========================================
+ Coverage 42.02% 65.02% +22.99%
===========================================
Files 148 284 +136
Lines 18131 26068 +7937
===========================================
+ Hits 7620 16951 +9331
+ Misses 9828 7530 -2298
- Partials 683 1587 +904
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel not a big problem to drop "kubectl get group".
Based on conversation I had with folks savvy with CRD code, this should be the only drawback. ie kubectl get with singular name will stop working.
|
/test-all |
@antoninbas @tnqn any feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates the singular name of the ClusterGroup CRD from "group" to "clustergroup". After this update, the "kubectl get group" command will not return any ClusterGroups. However, the most common way and the documented way to return ClusterGroups using kubectl have been to use "kubectl get cg" or "kubectl get clustergroups". Signed-off-by: abhiraut <rauta@vmware.com>
This PR updates the singular name of the ClusterGroup CRD from
group
toclustergroup
. After this update, thekubectl get group
command will not return any ClusterGroups. However, the most common way and the documented way to returnClusterGroups using kubectl have been to use
kubectl get cg
orkubectl get clustergroups
.Signed-off-by: abhiraut rauta@vmware.com