Install all Endpoint flows belong to a Service via single bundle #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-all |
|
/test-integration |
hongliangl
previously approved these changes
Jul 29, 2021
Codecov Report
@@ Coverage Diff @@
## main #2476 +/- ##
==========================================
+ Coverage 59.82% 64.77% +4.94%
==========================================
Files 284 284
Lines 22168 25583 +3415
==========================================
+ Hits 13263 16572 +3309
+ Misses 7483 7456 -27
- Partials 1422 1555 +133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
antoninbas
reviewed
Jul 29, 2021
pkg/agent/openflow/client.go
Outdated
| _, ok := cache.Load(flowCacheKey) | ||
| // If a flow cache entry already exists for the key, skip it. | ||
| if ok { | ||
| klog.V(2).Infof("Flows with cache key %s are already installed", flowCacheKey) |
| @@ -313,6 +313,41 @@ func (c *client) addFlows(cache *flowCategoryCache, flowCacheKey string, flows [ | |||
| return nil | |||
| } | |||
|
|
|||
| // addFlowsWithMultipleKeys installs the flows with different flowCache keys and adds them into the cache on success. | |||
| // Same as addFlows, it will skip flows whose cache already exists. All flows will be installed via a bundle. | |||
| func (c *client) addFlowsWithMultipleKeys(cache *flowCategoryCache, keyToFlows map[string][]binding.Flow) error { | |||
There was a problem hiding this comment.
it kinds of feels like this function should either call addFlows and re-use the code, or should replace it altogether. Am I missing something?
There was a problem hiding this comment.
You are right, addFlows can leverage addFlowsWithMultipleKeys. I have made the change to reduce code redundancy.
tnqn
force-pushed
the
improve-endpoint-flow
branch
from
556e2ac
to
904bcaa
Compare
It was observed that installing a bundle took around 1~3ms. In InstallEndpointFlows, agent created a bundle for each Endpoint and installed them sequentially. If there are many Services and Endpoints, it could take long time to install flows in this fashion when agent restarts. For instance, it took ~78s to install all flows for 4K Services and 28K Endpoints. This patch uses single bundle for all Endpoint flows belong to a Service to reduce the number of bundles. In the above scale, the execution time was reduced from ~78s to ~30s. Signed-off-by: Quan Tian <qtian@vmware.com>
tnqn
force-pushed
the
improve-endpoint-flow
branch
from
904bcaa
to
383d7c0
Compare
antoninbas
approved these changes
Jul 30, 2021
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was observed that installing a bundle took around 1~3ms. In
InstallEndpointFlows, agent created a bundle for each Endpoint and
installed them sequentially. If there are many Services and Endpoints,
it could take long time to install flows in this fashion when agent
restarts. For instance, it took ~78s to install all flows for 4K
Services and 28K Endpoints.
This patch uses single bundle for all Endpoint flows belong to a Service
to reduce the number of bundles. In the above scale, the execution time
was reduced from ~78s to ~30s.
Signed-off-by: Quan Tian qtian@vmware.com