-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPv6 flow for traceflowConnectionTrackFlows #2054
Conversation
Is this a bug fix? Does it explain some of the IPv6 Traceflow test failures? |
@gran-vmv @antoninbas : I think we should add a conntrackStateTable flow for IPv6 too. Could you check? |
I feel it could not explain the test failure I know (the UDP IPv6 failure in e2e tests). |
/test-ipv6-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I guess this would only be an issue for a TCPv6 Traceflow packet without the SYN flag set, which is probably not something we test
Codecov Report
@@ Coverage Diff @@
## main #2054 +/- ##
==========================================
- Coverage 61.06% 55.15% -5.92%
==========================================
Files 268 269 +1
Lines 20236 20374 +138
==========================================
- Hits 12357 11237 -1120
- Misses 6601 7934 +1333
+ Partials 1278 1203 -75
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@jianjuns Could you also fix this? #2029 (review) |
PR for this issue: #2059 |
/test-all |
No description provided.