Fix NetworkPolicy logging for IPv6 connections

[antoninbas]

The code in charge of parsing the PacketIn messages was only handling
IPv4 packets and not filling-in any information for IPv6 packets,
leading to logs with empty fields.

Fixes #1989

I ran the test successfully in an IPv6 cluster creating with Vagrant VMs:

=== RUN   TestAntreaPolicy/TestGroupAuditLogging
=== RUN   TestAntreaPolicy/TestGroupAuditLogging/Case=AuditLoggingBasic
I0324 16:58:27.096931   80575 entry.go:314] Creating/updating ClusterNetworkPolicy test-log-acnp-deny
I0324 16:58:40.655439   80575 entry.go:314] Deleting AntreaClusterNetworkPolicies test-log-acnp-deny
I0324 16:58:40.664245   80575 entry.go:314] Deleting test Namespace x
I0324 16:58:40.667629   80575 entry.go:314] Deleting test Namespace y
I0324 16:58:40.670239   80575 entry.go:314] Deleting test Namespace z
=== CONT  TestAntreaPolicy
    fixtures.go:338: Deleting 'antrea-test' K8s Namespace
--- PASS: TestAntreaPolicy (85.75s)
    --- PASS: TestAntreaPolicy/TestGroupAuditLogging (13.56s)
        --- PASS: TestAntreaPolicy/TestGroupAuditLogging/Case=AuditLoggingBasic (13.56s)
=== RUN   TestAntreaPolicyStatus
    fixtures.go:140: Creating 'antrea-test' K8s Namespace
    fixtures.go:103: Applying Antrea YAML
    fixtures.go:107: Waiting for all Antrea DaemonSet Pods
    fixtures.go:111: Checking CoreDNS deployment
    fixtures.go:345: Deleting Pod 'server-1vo3xb5yy'
    fixtures.go:345: Deleting Pod 'server-0krb06ddg'
    fixtures.go:338: Deleting 'antrea-test' K8s Namespace
--- PASS: TestAntreaPolicyStatus (21.07s)
PASS

[codecov-io]

Codecov Report

Merging #1990 (4239739) into main (cb840ce) will decrease coverage by 5.92%.
The diff coverage is 43.33%.

@@            Coverage Diff             @@
##             main    #1990      +/-   ##
==========================================
- Coverage   65.37%   59.44%   -5.93%     
==========================================
  Files         197      197              
  Lines       17217    17237      +20     
==========================================
- Hits        11256    10247    -1009     
- Misses       4786     5887    +1101     
+ Partials     1175     1103      -72     

Flag	Coverage Δ
kind-e2e-tests	44.65% <0.00%> (-11.80%)	⬇️
unit-tests	41.84% <43.33%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/ovs/openflow/ofctrl_action.go	47.84% <ø> (ø)
pkg/util/ip/ip.go	77.27% <38.46%> (-9.52%)	⬇️
pkg/agent/controller/networkpolicy/packetin.go	9.93% <47.05%> (-60.85%)	⬇️
pkg/apis/controlplane/helper.go	25.00% <0.00%> (-75.00%)	⬇️
pkg/apis/controlplane/v1beta2/helper.go	25.00% <0.00%> (-75.00%)	⬇️
pkg/controller/networkpolicy/store/group.go	6.66% <0.00%> (-73.34%)	⬇️
pkg/controller/networkpolicy/mutate.go	0.00% <0.00%> (-71.77%)	⬇️
pkg/controller/networkpolicy/validate.go	0.00% <0.00%> (-71.57%)	⬇️
pkg/k8s/name.go	33.33% <0.00%> (-66.67%)	⬇️
... and 41 more

[GraysonWu]

How about:

val, ok := opsv1alpha1.ProtocolsToString[int32(prot)]
if !ok {
    val = "UnsupportProtocol"
}
ob.protocolStr = val

And add ICMPv6 related info to ProtocolsToString?

[antoninbas]

Thanks for the suggestion. I added support for IPv6-ICMP, and I removed the dependency on the ops API types, as it didn't make sense to me.

[tnqn]

LGTM, thanks for fixing it so quickly

[antoninbas]

/test-all

[GraysonWu]

LGTM.