Do not construct intermediate sets when calculating union of multiple sets #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1938 +/- ##
==========================================
- Coverage 62.49% 58.61% -3.88%
==========================================
Files 202 203 +1
Lines 17480 17482 +2
==========================================
- Hits 10924 10247 -677
- Misses 5388 6120 +732
+ Partials 1168 1115 -53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-all |
|
/test-integration |
antoninbas
previously approved these changes
Mar 4, 2021
pkg/util/sets/string.go
Outdated
| // Merge(s1, s2) = {a1, a2, a3, a4, a5} | ||
| // s1 = {a1, a2, a3, a4, a5} | ||
| // | ||
| // It supersedes s1.Union(s2) when constructing a new sets is not the intention. |
Dyanngg
previously approved these changes
Mar 4, 2021
… sets An AddressGroup can be shared by multiple NetworkPolicies and its span is the union of the NetworkPolicies'. The syncAddressGroup method uses "Union" method to calculate the union set. However, the method always create a new sets and copies the original items when traversing each set. This performs badly when the number of the NetworkPolicies increase and the span is big. This patch optimizes it by using a "Merge" function to avoid above cost. The benchmark impact is as below when there are 1000 NetworkPolicies sharing the AddressGroup and the span is 1000 Nodes: name old time/op new time/op delta SyncAddressGroup-48 417µs ± 4% 326µs ± 4% -21.91% (p=0.008 n=5+5) name old alloc/op new alloc/op delta SyncAddressGroup-48 98.9kB ± 0% 51.1kB ± 1% -48.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta SyncAddressGroup-48 1.05k ± 0% 0.05k ± 8% -94.78% (p=0.008 n=5+5)
antoninbas
approved these changes
Mar 5, 2021
|
/test-all |
|
Merging it as jenkins-windows-networkpolicy succeeded before I fixed the typo. |
tnqn
added a commit
to tnqn/antrea
that referenced
this pull request
Mar 17, 2021
… sets (antrea-io#1938) An AddressGroup can be shared by multiple NetworkPolicies and its span is the union of the NetworkPolicies'. The syncAddressGroup method uses "Union" method to calculate the union set. However, the method always create a new sets and copies the original items when traversing each set. This performs badly when the number of the NetworkPolicies increase and the span is big. This patch optimizes it by using a "Merge" function to avoid above cost. The benchmark impact is as below when there are 1000 NetworkPolicies sharing the AddressGroup and the span is 1000 Nodes: name old time/op new time/op delta SyncAddressGroup-48 417µs ± 4% 326µs ± 4% -21.91% (p=0.008 n=5+5) name old alloc/op new alloc/op delta SyncAddressGroup-48 98.9kB ± 0% 51.1kB ± 1% -48.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta SyncAddressGroup-48 1.05k ± 0% 0.05k ± 8% -94.78% (p=0.008 n=5+5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An AddressGroup can be shared by multiple NetworkPolicies and its span
is the union of the NetworkPolicies'. The syncAddressGroup method uses
"Union" method to calculate the union set. However, the method always
create a new sets and copies the original items when traversing each
set. This performs badly when the number of the NetworkPolicies increase
and the span is big.
This patch optimizes it by using a "Merge" function to avoid above cost.
The benchmark impact is as below when there are 1000 NetworkPolicies
sharing the AddressGroup and the span is 1000 Nodes: