-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Kibana dashboard and the screenshots in doc #1933
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1933 +/- ##
==========================================
- Coverage 62.46% 61.75% -0.71%
==========================================
Files 201 201
Lines 17377 17377
==========================================
- Hits 10854 10731 -123
- Misses 5365 5491 +126
+ Partials 1158 1155 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, any noteworthy change in kibana.ndjson?
Thanks! As I mentioned in description. In Kibana.ndjson we add color-coding by network policies and show flows with no network policies in pie chart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the network policy snapshots, color-coded groups are not consistent with colors on vertical ingress and egress lines. Is this expected? If expected please specify what they correspond to for avoiding any confusion.
Yes, it is expected. That is to distinguish source and destination pod of each flow. If they are using the same color, Kibana will treat flows under the same network policy as a whole that we cannot tell the throughput of single flow. |
I feel users could use Pod-to-Pod flow dashboard to figure out the throughput IMO. In network policy dashboard, if feasible, we can use the same color code for all the flows involving the same network policy even on the left vertical line. If not feasible, please add the above clarification in the document, where we add the note of network policy color coding. |
faa0675
to
00a1b1c
Compare
00a1b1c
to
d94d622
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. Modified Sankey diagrams look good.
One clarification: the color of flow pipes is based on source and destination tuple and that is why they are unique?
docs/network-flow-visibility.md
Outdated
network policy name and namespace to view corresponding flow throughput under network policy. Flows | ||
are grouped and color-coded by network policies in the sankey diagram. When hovering over the flow, | ||
it will show corresponding Pod-to-Pod traffic details and network policies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this description of color coding for network policy should be modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Thanks!
de5e1f7
to
bcabfc6
Compare
This commit improves network policy diagram by grouping flows by egress and ingress network policy as source and destination, respectively. It also shows the flows with no network policy in pie chart to provide complete information. It also updates the screenshots of Kibana dashboard with better sankey diagrams (more variety).
bcabfc6
to
38ce71f
Compare
Yes, I think this looks better and IMO users could easily distinguish network policies and flows going through them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/skip-all |
This commit improves network policy diagram by grouping flows by egress and ingress network policy as source and destination, respectively. It also shows the flows with no network policy in pie chart to provide complete information. It also updates the screenshots of Kibana dashboard with better sankey diagrams (more variety).
This commit improves network policy diagram by grouping flows by egress and ingress network policy as source and destination, respectively. It also shows the flows with no network policy in pie chart to provide complete information. It also updates the screenshots of Kibana dashboard with better sankey diagrams (more variety).
This commit improves network policy diagram by grouping and color-coding flows using network policy. It shows the flows with no network policy in pie chart to provide complete information.
It also updates the screenshots of Kibana dashboard with better sankey diagrams (more variety). Example: