Clean up stale IP addresses on Antrea host gateway #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration test has to be run manually on Windows: |
tnqn
previously approved these changes
Feb 25, 2021
|
/test-all |
|
/test-ipv6-all |
Codecov Report
@@ Coverage Diff @@
## main #1900 +/- ##
=======================================
Coverage ? 53.04%
=======================================
Files ? 201
Lines ? 17284
Branches ? 0
=======================================
Hits ? 9169
Misses ? 6953
Partials ? 1162
Flags with carried forward coverage won't be shown. Click here to find out more. |
ruicao93
reviewed
Feb 25, 2021
pkg/agent/util/net_windows.go
Outdated
| return addr1.IP.Equal(addr2.IP) && size1 == size2 | ||
| } | ||
|
|
||
| addrSliceDifference := func(s1, s2 []*net.IPNet) []*net.IPNet { |
There was a problem hiding this comment.
Do you consider to move the function out to make it a util function?
There was a problem hiding this comment.
Asked the same question in net_linux.go :)
There was a problem hiding this comment.
I extracted the function definition. However, note that the signature is different for the Linux & Windows case. When go has support for generics, we can have a true common utility function to compute slice differences.
ruicao93
reviewed
Feb 25, 2021
ruicao93
reviewed
Feb 25, 2021
jianjuns
previously approved these changes
Feb 25, 2021
pkg/agent/util/net_linux.go
Outdated
| } | ||
| } | ||
|
|
||
| addrSliceDifference := func(s1, s2 []netlink.Addr) []*netlink.Addr { |
There was a problem hiding this comment.
Do you think it helps to move the func to an independent one?
pkg/agent/util/net_windows.go
Outdated
| return addr1.IP.Equal(addr2.IP) && size1 == size2 | ||
| } | ||
|
|
||
| addrSliceDifference := func(s1, s2 []*net.IPNet) []*net.IPNet { |
There was a problem hiding this comment.
Asked the same question in net_linux.go :)
When a Node leaves a K8s cluster and joins it again later, it is likely that it will receive a different Pod CIDR. If we simply add the new gateway IP (first IP in the CIDR) to the host gateway interface without removing the previous one, we have observed that it can lead to connectivity issues. This commit ensures that all stale IPs are removed when configuring the gateway interface on an Agent restart. Link-local addresses are left untouched. An integration test is added for both Linux & Windows. Fixes antrea-io#1685
antoninbas
force-pushed
the
cleanup-stale-addresses-on-gw
branch
from
326f82f
to
3b086f4
Compare
|
/test-all |
|
/test-all |
jianjuns
approved these changes
Feb 25, 2021
|
/test-ipv6-only-networkpolicy |
1 similar comment
|
/test-ipv6-only-networkpolicy |
|
|
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Feb 25, 2021
When a Node leaves a K8s cluster and joins it again later, it is likely that it will receive a different Pod CIDR. If we simply add the new gateway IP (first IP in the CIDR) to the host gateway interface without removing the previous one, we have observed that it can lead to connectivity issues. This commit ensures that all stale IPs are removed when configuring the gateway interface on an Agent restart. Link-local addresses are left untouched. An integration test is added for both Linux & Windows. Fixes antrea-io#1685
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Feb 25, 2021
When a Node leaves a K8s cluster and joins it again later, it is likely that it will receive a different Pod CIDR. If we simply add the new gateway IP (first IP in the CIDR) to the host gateway interface without removing the previous one, we have observed that it can lead to connectivity issues. This commit ensures that all stale IPs are removed when configuring the gateway interface on an Agent restart. Link-local addresses are left untouched. An integration test is added for both Linux & Windows. Fixes antrea-io#1685
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Feb 26, 2021
When a Node leaves a K8s cluster and joins it again later, it is likely that it will receive a different Pod CIDR. If we simply add the new gateway IP (first IP in the CIDR) to the host gateway interface without removing the previous one, we have observed that it can lead to connectivity issues. This commit ensures that all stale IPs are removed when configuring the gateway interface on an Agent restart. Link-local addresses are left untouched. An integration test is added for both Linux & Windows. Fixes antrea-io#1685
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Feb 26, 2021
When a Node leaves a K8s cluster and joins it again later, it is likely that it will receive a different Pod CIDR. If we simply add the new gateway IP (first IP in the CIDR) to the host gateway interface without removing the previous one, we have observed that it can lead to connectivity issues. This commit ensures that all stale IPs are removed when configuring the gateway interface on an Agent restart. Link-local addresses are left untouched. An integration test is added for both Linux & Windows. Fixes antrea-io#1685
antoninbas
added a commit
that referenced
this pull request
Feb 26, 2021
When a Node leaves a K8s cluster and joins it again later, it is likely that it will receive a different Pod CIDR. If we simply add the new gateway IP (first IP in the CIDR) to the host gateway interface without removing the previous one, we have observed that it can lead to connectivity issues. This commit ensures that all stale IPs are removed when configuring the gateway interface on an Agent restart. Link-local addresses are left untouched. An integration test is added for both Linux & Windows. Fixes #1685
antoninbas
added a commit
that referenced
this pull request
Feb 26, 2021
When a Node leaves a K8s cluster and joins it again later, it is likely that it will receive a different Pod CIDR. If we simply add the new gateway IP (first IP in the CIDR) to the host gateway interface without removing the previous one, we have observed that it can lead to connectivity issues. This commit ensures that all stale IPs are removed when configuring the gateway interface on an Agent restart. Link-local addresses are left untouched. An integration test is added for both Linux & Windows. Fixes #1685
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Mar 11, 2021
When a Node leaves a K8s cluster and joins it again later, it is likely that it will receive a different Pod CIDR. If we simply add the new gateway IP (first IP in the CIDR) to the host gateway interface without removing the previous one, we have observed that it can lead to connectivity issues. This commit ensures that all stale IPs are removed when configuring the gateway interface on an Agent restart. Link-local addresses are left untouched. An integration test is added for both Linux & Windows. Fixes antrea-io#1685
antoninbas
added a commit
that referenced
this pull request
Mar 12, 2021
When a Node leaves a K8s cluster and joins it again later, it is likely that it will receive a different Pod CIDR. If we simply add the new gateway IP (first IP in the CIDR) to the host gateway interface without removing the previous one, we have observed that it can lead to connectivity issues. This commit ensures that all stale IPs are removed when configuring the gateway interface on an Agent restart. Link-local addresses are left untouched. An integration test is added for both Linux & Windows. Fixes #1685
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Node leaves a K8s cluster and joins it again later, it is likely
that it will receive a different Pod CIDR. If we simply add the new
gateway IP (first IP in the CIDR) to the host gateway interface without
removing the previous one, we have observed that it can lead to
connectivity issues. This commit ensures that all stale IPs are removed
when configuring the gateway interface on an Agent restart. Link-local
addresses are left untouched. An integration test is added for both
Linux & Windows.
Fixes #1685