Add code coverage for flow aggregator #1898

srikartati · 2021-02-23T20:57:23Z

Add code coverage for flow aggregator binary when
running end-to-end tests on different platforms
(kind, jenkins, VMC etc.)

codecov-io · 2021-02-23T21:01:47Z

Codecov Report

Merging #1898 (abfe254) into main (d1a9fe1) will decrease coverage by 16.29%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1898       +/-   ##
===========================================
- Coverage   62.56%   46.27%   -16.30%     
===========================================
  Files         204      187       -17     
  Lines       17534    16788      -746     
===========================================
- Hits        10970     7768     -3202     
- Misses       5402     8009     +2607     
+ Partials     1162     1011      -151

Flag	Coverage Δ
e2e-tests	`46.27% <ø> (?)`
kind-e2e-tests	`?`
unit-tests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/controller/networkpolicy/crd_utils.go	`0.00% <0.00%> (-90.22%)`	⬇️
pkg/controller/networkpolicy/status_controller.go	`0.00% <0.00%> (-88.82%)`	⬇️
...g/controller/networkpolicy/clusternetworkpolicy.go	`0.00% <0.00%> (-86.96%)`	⬇️
...kg/controller/networkpolicy/antreanetworkpolicy.go	`0.00% <0.00%> (-84.70%)`	⬇️
pkg/controller/networkpolicy/endpoint_querier.go	`2.70% <0.00%> (-83.79%)`	⬇️
pkg/ipfix/ipfix_process.go	`0.00% <0.00%> (-81.82%)`	⬇️
pkg/agent/util/iptables/lock.go	`0.00% <0.00%> (-81.82%)`	⬇️
pkg/agent/controller/networkpolicy/priority.go	`8.49% <0.00%> (-81.70%)`	⬇️
pkg/ipfix/ipfix_set.go	`20.00% <0.00%> (-80.00%)`	⬇️
pkg/apis/controlplane/v1beta1/conversion.go	`1.16% <0.00%> (-79.85%)`	⬇️
... and 114 more

antoninbas

I see no logic in the e2e test framework to retrieve the coverage file for the flow aggregator and copy it to the correct directory?

https://github.com/vmware-tanzu/antrea/blob/6485421be9da2e97b1fc3f7a180cccb2dc053a7f/test/e2e/framework.go#L1571-L1643

dreamtalen

Thanks for your PR.

dreamtalen · 2021-02-24T18:17:45Z

build/yamls/flow-aggregator/patches/coverage/startFlowAggCov.yml

+        command:
+          - flow-aggregator-coverage
+        name: flow-aggregator
+        image: antrea/flow-aggregator-coverage:latest


Missing a blank new line.

dreamtalen · 2021-02-24T18:18:35Z

ci/jenkins/test-vmc.sh

@@ -298,7 +298,11 @@ function deliver_antrea {
            VERSION="$CLUSTER" DOCKER_REGISTRY="${DOCKER_REGISTRY}" make && break
        fi
    done
-    VERSION="$CLUSTER" DOCKER_REGISTRY="${DOCKER_REGISTRY}" make flow-aggregator-ubuntu
+    if [[ "$COVERAGE" == true ]]; then
+      VERSION="$CLUSTER" DOCKER_REGISTRY="${DOCKER_REGISTRY}" make flow-aggregator-ubuntu


swap L302 and L304?

Yes, thats right. It was a mistake. Done.

srikartati · 2021-02-24T19:54:11Z

ci/jenkins/test-vmc.sh

@@ -298,7 +298,11 @@ function deliver_antrea {
            VERSION="$CLUSTER" DOCKER_REGISTRY="${DOCKER_REGISTRY}" make && break
        fi
    done
-    VERSION="$CLUSTER" DOCKER_REGISTRY="${DOCKER_REGISTRY}" make flow-aggregator-ubuntu
+    if [[ "$COVERAGE" == true ]]; then
+      VERSION="$CLUSTER" DOCKER_REGISTRY="${DOCKER_REGISTRY}" make flow-aggregator-ubuntu


Yes, thats right. It was a mistake. Done.

test/e2e/framework.go

srikartati · 2021-02-25T05:54:22Z

/test-all

antoninbas

@weiqiangt I believe the codecov token is wrong, or something along these lines. The codecov reports are not being uploaded to the correct place. When I look at some logs for Github workflows running on the main branch, I see:

View reports at https://codecov.io/github/weiqiangt/antrea/commit/c9f526066d20de477ac2126f14090e1f4bfd8d6e

So I think we may be using a token for your personal fork and not for vmware-tanzu/antrea. I don't want to merge this PR before this is fixed, as I want to check that the coverage data for the aggregator is handled correctly.

Maybe I need to update the token myself?

antoninbas · 2021-02-26T01:10:18Z

test/e2e/framework.go

+	}
+	pods, err := data.clientset.CoreV1().Pods(flowAggregatorNamespace).List(context.TODO(), listOptions)
+	if err != nil {
+		return fmt.Errorf("failed to list Flow Aggregator: %v", err)


list Flow Aggregator Pods

srikartati · 2021-02-26T01:40:48Z

@weiqiangt I believe the codecov token is wrong, or something along these lines. The codecov reports are not being uploaded to the correct place. When I look at some logs for Github workflows running on the main branch, I see:
View reports at https://codecov.io/github/weiqiangt/antrea/commit/c9f526066d20de477ac2126f14090e1f4bfd8d6e
So I think we may be using a token for your personal fork and not for vmware-tanzu/antrea. I don't want to merge this PR before this is fixed, as I want to check that the coverage data for the aggregator is handled correctly.

Maybe I need to update the token myself?

I checked cov.out files in the kind e2e test artifacts and code coverage output for flow aggregator seemed to have populated there fine. Yes, I tried codecov UI, but could not locate it. I created my PR before the main branch fix went in. Does it have to do something with that?

antoninbas · 2021-02-26T21:13:22Z

I didn't hear from @weiqiangt about this, so I'll try updating the token myself to see if it resolves the issue

srikartati · 2021-02-26T22:25:49Z

/test-all

antoninbas · 2021-02-26T23:12:23Z

@srikartati I think I have fixed the issue by changing the token
Could you rebase your PR on main?

srikartati · 2021-02-26T23:47:02Z

/test-all

srikartati · 2021-02-27T07:53:15Z

/test-all

srikartati · 2021-03-01T22:32:33Z

/test-all

antoninbas

Looks like the coverage data is uploaded correctly now

Add code coverage for flow aggregator binary when running end-to-end tests on different platforms (kind, jenkins, VMC etc.)

srikartati · 2021-03-05T23:14:17Z

/test-all

srikartati · 2021-03-08T18:53:21Z

/test-conformance

Add code coverage for flow aggregator binary when running end-to-end tests on different platforms (kind, jenkins, VMC etc.)

vmwclabot added the cla-not-required label Feb 23, 2021

srikartati force-pushed the flow_agg_code_coverage branch 2 times, most recently from 0bdf69f to 43766ca Compare February 23, 2021 22:15

srikartati requested review from antoninbas and dreamtalen February 23, 2021 22:33

antoninbas reviewed Feb 23, 2021

View reviewed changes

srikartati force-pushed the flow_agg_code_coverage branch 2 times, most recently from 9f8cbee to 34881f3 Compare February 24, 2021 18:20

dreamtalen reviewed Feb 24, 2021

View reviewed changes

srikartati commented Feb 24, 2021

View reviewed changes

srikartati force-pushed the flow_agg_code_coverage branch from 34881f3 to f131c4d Compare February 24, 2021 19:56

srikartati requested a review from antoninbas February 25, 2021 19:45

antoninbas reviewed Feb 26, 2021

View reviewed changes

srikartati force-pushed the flow_agg_code_coverage branch 2 times, most recently from 6a03e30 to 7261a51 Compare February 26, 2021 20:08

srikartati force-pushed the flow_agg_code_coverage branch from 7261a51 to 24b7cfd Compare February 26, 2021 23:17

srikartati force-pushed the flow_agg_code_coverage branch 5 times, most recently from 88d0cfe to 47335d6 Compare February 27, 2021 06:58

srikartati force-pushed the flow_agg_code_coverage branch from 47335d6 to f2b942c Compare March 1, 2021 19:13

antoninbas previously approved these changes Mar 1, 2021

View reviewed changes

srikartati dismissed antoninbas’s stale review via 9ef3e20 March 2, 2021 14:39

srikartati force-pushed the flow_agg_code_coverage branch 6 times, most recently from dad463d to 831e1de Compare March 5, 2021 17:42

Add code coverage for flow aggregator

e8f4ccf

Add code coverage for flow aggregator binary when running end-to-end tests on different platforms (kind, jenkins, VMC etc.)

srikartati force-pushed the flow_agg_code_coverage branch from 831e1de to e8f4ccf Compare March 5, 2021 20:47

srikartati requested a review from antoninbas March 10, 2021 16:10

antoninbas approved these changes Mar 10, 2021

View reviewed changes

srikartati merged commit b36103a into antrea-io:main Mar 10, 2021

srikartati deleted the flow_agg_code_coverage branch March 10, 2021 21:38

srikartati mentioned this pull request Mar 15, 2021

e2e cases failed quite often after testing TestFlowAggregator #1956

Closed

tnqn pushed a commit to tnqn/antrea that referenced this pull request Mar 17, 2021

Add code coverage for flow aggregator (antrea-io#1898)

26a5594

Add code coverage for flow aggregator binary when running end-to-end tests on different platforms (kind, jenkins, VMC etc.)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add code coverage for flow aggregator #1898

Add code coverage for flow aggregator #1898

srikartati commented Feb 23, 2021

codecov-io commented Feb 23, 2021 •

edited

Loading

antoninbas left a comment

dreamtalen left a comment

dreamtalen Feb 24, 2021

dreamtalen Feb 24, 2021

srikartati Feb 24, 2021

srikartati Feb 24, 2021

srikartati commented Feb 25, 2021

antoninbas left a comment

antoninbas Feb 26, 2021

srikartati commented Feb 26, 2021 •

edited

Loading

antoninbas commented Feb 26, 2021

srikartati commented Feb 26, 2021

antoninbas commented Feb 26, 2021

srikartati commented Feb 26, 2021

srikartati commented Feb 27, 2021

srikartati commented Mar 1, 2021

antoninbas left a comment

srikartati commented Mar 5, 2021

srikartati commented Mar 8, 2021

Add code coverage for flow aggregator #1898

Add code coverage for flow aggregator #1898

Conversation

srikartati commented Feb 23, 2021

codecov-io commented Feb 23, 2021 • edited Loading

Codecov Report

antoninbas left a comment

Choose a reason for hiding this comment

dreamtalen left a comment

Choose a reason for hiding this comment

dreamtalen Feb 24, 2021

Choose a reason for hiding this comment

dreamtalen Feb 24, 2021

Choose a reason for hiding this comment

srikartati Feb 24, 2021

Choose a reason for hiding this comment

srikartati Feb 24, 2021

Choose a reason for hiding this comment

srikartati commented Feb 25, 2021

antoninbas left a comment

Choose a reason for hiding this comment

antoninbas Feb 26, 2021

Choose a reason for hiding this comment

srikartati commented Feb 26, 2021 • edited Loading

antoninbas commented Feb 26, 2021

srikartati commented Feb 26, 2021

antoninbas commented Feb 26, 2021

srikartati commented Feb 26, 2021

srikartati commented Feb 27, 2021

srikartati commented Mar 1, 2021

antoninbas left a comment

Choose a reason for hiding this comment

srikartati commented Mar 5, 2021

srikartati commented Mar 8, 2021

codecov-io commented Feb 23, 2021 •

edited

Loading

srikartati commented Feb 26, 2021 •

edited

Loading