Update the network flow visibility doc #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. The following commands are available:
|
As Flow Exporter supports adding network policy information, we need to update the user doc.
srikartati
force-pushed
the
update_net_visibility_doc
branch
from
de7a59b
to
a7e08ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #1535 +/- ##
===========================================
- Coverage 63.31% 41.00% -22.32%
===========================================
Files 170 105 -65
Lines 14250 12655 -1595
===========================================
- Hits 9023 5189 -3834
- Misses 4292 6999 +2707
+ Partials 935 467 -468
Flags with carried forward coverage won't be shown. Click here to find out more.
|
antoninbas
reviewed
Nov 12, 2020
docs/network-flow-visibility.md
Outdated
| the flow record from the destination Node, where the destination Pod resides. Due | ||
| to this we miss key information such as destination Pod info, ingress NetworkPolicy | ||
| info, stats from the destination Node, etc. In the future, this behavior will be | ||
| changed when we add the support for the correlation of the flow records that belong |
There was a problem hiding this comment.
when we add support for correlating the different flow records (from source and destination Nodes) that belong to the same flow
There was a problem hiding this comment.
I edited the file directly, hope you don't mind
|
/skip-all |
antoninbas
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Flow Exporter supports adding network policy information,
we need to update the user doc.