Update documentation for e2e tests on kind cluster #1307

srikartati · 2020-09-26T01:25:46Z

Add details on running the e2e tests on a kind cluster
with the local Antrea image.

Felt these additional details in the documentation for dev process on kind cluster.

antrea-bot · 2020-09-26T01:26:02Z

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

/test-e2e: to trigger e2e tests.
/skip-e2e: to skip e2e tests.
/test-conformance: to trigger conformance tests.
/skip-conformance: to skip conformance tests.
/test-whole-conformance: to trigger all conformance tests on linux.
/skip-whole-conformance: to skip all conformance tests on linux.
/test-networkpolicy: to trigger networkpolicy tests.
/skip-networkpolicy: to skip networkpolicy tests.
/test-windows-conformance: to trigger windows conformance tests.
/skip-windows-conformance: to skip windows conformance tests.
/test-windows-networkpolicy: to trigger windows networkpolicy tests.
/skip-windows-networkpolicy: to skip windows networkpolicy tests.
/test-hw-offload: to trigger ovs hardware offload test.
/skip-hw-offload: to skip ovs hardware offload test.
/test-all: to trigger all tests (except whole conformance).
/skip-all: to skip all tests (except whole conformance).

codecov-commenter · 2020-09-26T01:30:01Z

Codecov Report

Merging #1307 into master will decrease coverage by 9.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1307      +/-   ##
==========================================
- Coverage   63.63%   54.45%   -9.19%     
==========================================
  Files         157      119      -38     
  Lines       12626    11241    -1385     
==========================================
- Hits         8035     6121    -1914     
- Misses       3748     4528     +780     
+ Partials      843      592     -251

Flag	Coverage Δ
#integration-tests	`44.75% <ø> (-0.04%)`	⬇️
#kind-e2e-tests	`?`
#unit-tests	`42.19% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/agent/agent_linux.go	`0.00% <0.00%> (-100.00%)`	⬇️
pkg/controller/networkpolicy/tier.go	`0.00% <0.00%> (-100.00%)`	⬇️
pkg/agent/proxy/types/groupcounter.go	`0.00% <0.00%> (-95.00%)`	⬇️
pkg/apis/controlplane/register.go	`0.00% <0.00%> (-85.72%)`	⬇️
pkg/apis/stats/register.go	`0.00% <0.00%> (-81.82%)`	⬇️
pkg/agent/client.go	`0.00% <0.00%> (-77.42%)`	⬇️
pkg/agent/util/ethtool/ethtool_linux.go	`0.00% <0.00%> (-70.00%)`	⬇️
...kg/apiserver/registry/system/supportbundle/rest.go	`9.88% <0.00%> (-65.70%)`	⬇️
pkg/querier/querier.go	`0.00% <0.00%> (-57.15%)`	⬇️
pkg/agent/util/iptables/iptables.go	`6.25% <0.00%> (-56.25%)`	⬇️
... and 91 more

tnqn · 2020-09-28T13:13:36Z

test/e2e/README.md

@@ -149,6 +149,14 @@ manifest to the master Docker container:
 go test -v github.com/vmware-tanzu/antrea/test/e2e -provider=kind
 ```

+You can also run the e2e tests on an existing e2e cluster with the local Antrea


The first sentence sounds a little confusing as the above paragraph also says "You can also run the e2e tests with an existing Kind cluster.", this paragraph repeated it but changed "Kind cluster" to "e2e cluster". I feel perhaps adding the image load command to the above paragraph and instructions is more clear and fits for reading's order.

Yes that was a typo from my end. I will rephrase.

tnqn

LGTM

srikartati · 2020-11-17T11:35:16Z

/skip-all

Add details on running the e2e tests on a kind cluster with the local Antrea image.

antrea-bot · 2020-11-17T12:17:32Z

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

/test-e2e: to trigger e2e tests.
/skip-e2e: to skip e2e tests.
/test-conformance: to trigger conformance tests.
/skip-conformance: to skip conformance tests.
/test-all-features-conformance: to trigger conformance tests with all alpha features enabled.
/skip-all-features-conformance: to skip conformance tests with all alpha features enabled.
/test-whole-conformance: to trigger all conformance tests on linux.
/skip-whole-conformance: to skip all conformance tests on linux.
/test-networkpolicy: to trigger networkpolicy tests.
/skip-networkpolicy: to skip networkpolicy tests.
/test-windows-conformance: to trigger windows conformance tests.
/skip-windows-conformance: to skip windows conformance tests.
/test-windows-networkpolicy: to trigger windows networkpolicy tests.
/skip-windows-networkpolicy: to skip windows networkpolicy tests.
/test-hw-offload: to trigger ovs hardware offload test.
/skip-hw-offload: to skip ovs hardware offload test.
/test-all: to trigger all tests (except whole conformance).
/skip-all: to skip all tests (except whole conformance).

codecov-io · 2020-11-17T12:40:48Z

Codecov Report

Merging #1307 (584ab29) into master (9d3d10b) will decrease coverage by 22.59%.
The diff coverage is 10.60%.

@@             Coverage Diff             @@
##           master    #1307       +/-   ##
===========================================
- Coverage   63.31%   40.72%   -22.60%     
===========================================
  Files         170      106       -64     
  Lines       14250    12747     -1503     
===========================================
- Hits         9023     5191     -3832     
- Misses       4292     7090     +2798     
+ Partials      935      466      -469

Flag	Coverage Δ
kind-e2e-tests	`?`
unit-tests	`40.72% <10.60%> (-0.56%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/antrea-agent/agent.go	`0.00% <0.00%> (ø)`
cmd/antrea-agent/options.go	`21.69% <0.00%> (+0.97%)`	⬆️
pkg/agent/agent.go	`12.05% <0.00%> (-36.67%)`	⬇️
pkg/agent/agent_linux.go	`0.00% <0.00%> (-100.00%)`	⬇️
pkg/agent/config/node_config.go	`0.00% <ø> (-100.00%)`	⬇️
.../agent/flowexporter/connections/conntrack_linux.go	`28.37% <0.00%> (-0.79%)`	⬇️
pkg/agent/openflow/pipeline.go	`28.17% <0.00%> (-41.61%)`	⬇️
pkg/agent/stats/collector.go	`51.13% <ø> (-46.60%)`	⬇️
pkg/apiserver/certificate/cacert_controller.go	`10.81% <0.00%> (-45.58%)`	⬇️
pkg/controller/networkpolicy/mutate.go	`0.00% <0.00%> (ø)`
... and 154 more

srikartati · 2020-11-18T03:50:59Z

/skip-all

srikartati · 2020-11-18T11:09:55Z

LGTM

I rebased the patch. Could you please reapprove?

vmwclabot added the cla-not-required label Sep 26, 2020

srikartati requested a review from antoninbas September 26, 2020 01:25

srikartati requested a review from jianjuns September 26, 2020 01:26

srikartati force-pushed the update_kind_doc branch from 5012b78 to 3a5b5a3 Compare September 26, 2020 01:27

srikartati force-pushed the update_kind_doc branch from 3a5b5a3 to 6b9f998 Compare September 26, 2020 01:30

tnqn reviewed Sep 28, 2020

View reviewed changes

srikartati force-pushed the update_kind_doc branch from 6b9f998 to 7bc2f2f Compare November 2, 2020 18:54

srikartati requested a review from tnqn November 2, 2020 18:55

tnqn previously approved these changes Nov 17, 2020

View reviewed changes

Update documentation for e2e test on kind cluster

584ab29

Add details on running the e2e tests on a kind cluster with the local Antrea image.

srikartati dismissed tnqn’s stale review via 584ab29 November 17, 2020 12:17

srikartati force-pushed the update_kind_doc branch from 7bc2f2f to 584ab29 Compare November 17, 2020 12:17

srikartati requested a review from tnqn November 17, 2020 18:25

tnqn approved these changes Nov 18, 2020

View reviewed changes

srikartati merged commit b1745fc into antrea-io:master Nov 18, 2020

srikartati deleted the update_kind_doc branch November 18, 2020 12:13

antoninbas mentioned this pull request Nov 18, 2020

Run markdownlint as part of CI #1569

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update documentation for e2e tests on kind cluster #1307

Update documentation for e2e tests on kind cluster #1307

srikartati commented Sep 26, 2020

antrea-bot commented Sep 26, 2020

codecov-commenter commented Sep 26, 2020 •

edited

Loading

tnqn Sep 28, 2020

srikartati Sep 29, 2020

tnqn left a comment

srikartati commented Nov 17, 2020

antrea-bot commented Nov 17, 2020

codecov-io commented Nov 17, 2020

srikartati commented Nov 18, 2020

srikartati commented Nov 18, 2020

Update documentation for e2e tests on kind cluster #1307

Update documentation for e2e tests on kind cluster #1307

Conversation

srikartati commented Sep 26, 2020

antrea-bot commented Sep 26, 2020

codecov-commenter commented Sep 26, 2020 • edited Loading

Codecov Report

tnqn Sep 28, 2020

Choose a reason for hiding this comment

srikartati Sep 29, 2020

Choose a reason for hiding this comment

tnqn left a comment

Choose a reason for hiding this comment

srikartati commented Nov 17, 2020

antrea-bot commented Nov 17, 2020

codecov-io commented Nov 17, 2020

Codecov Report

srikartati commented Nov 18, 2020

srikartati commented Nov 18, 2020

codecov-commenter commented Sep 26, 2020 •

edited

Loading