Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release assets for Windows #1061

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Add release assets for Windows #1061

merged 1 commit into from
Aug 12, 2020

Conversation

ruicao93
Copy link
Contributor

Add following files in release assets for Windows:

  • antrea-agent-windows-x86_64.exe
  • antrea-cni-windows-x86_64.exe
  • Start.ps1: The script can be used to install antrea-agent and
    start it as process manually on Windows worker node.

Signed-off-by: Rui Cao rcao@vmware.com

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-hw-offload: to trigger ovs hardware offload test.
  • /skip-hw-offload: to skip ovs hardware offload test.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

@ruicao93 ruicao93 added this to the Antrea v0.9.0 release milestone Aug 11, 2020
antoninbas
antoninbas reviewed Aug 11, 2020
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait until #1013 is merged to merge this PR

.github/workflows/upload_release_assets.yml Show resolved Hide resolved
@ruicao93
Add release assets for Windows (antrea-io#1061)
d9c5ea1 
Add following files in release assets for Windows:
- antrea-agent-windows-x86_64.exe
- antrea-cni-windows-x86_64.exe
- Start.ps1: The script can be used to install antrea-agent and
  start it as process manually on Windows worker node.

Signed-off-by: Rui Cao <rcao@vmware.com>
@ruicao93
Copy link
Contributor Author

/skip-all

1 similar comment
@ruicao93
Copy link
Contributor Author

/skip-all

@ruicao93
Copy link
Contributor Author

@antoninbas #1013 has been merged, could you help approve this PR?

antoninbas
antoninbas approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas antoninbas merged commit 79dbe15 into antrea-io:master Aug 12, 2020
antoninbas added a commit to antoninbas/antrea that referenced this pull request Aug 12, 2020
@antoninbas
Fix YAML syntax in "Upload assets to release" workflow
52f1926 
Github is reporting that the syntax introduced by
antrea-io#1061 is not correct, so the
workflow cannot run.
@antoninbas antoninbas mentioned this pull request Aug 12, 2020
Merged
antoninbas added a commit that referenced this pull request Aug 13, 2020
@antoninbas
Fix YAML syntax in "Upload assets to release" workflow (#1072)
54a7b53 
Github is reporting that the syntax introduced by
#1061 is not correct, so the
workflow cannot run.
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
@ruicao93 @GraysonWu
Add release assets for Windows (antrea-io#1061) (antrea-io#1061)
c00cfd1 
Add following files in release assets for Windows:
- antrea-agent-windows-x86_64.exe
- antrea-cni-windows-x86_64.exe
- Start.ps1: The script can be used to install antrea-agent and
  start it as process manually on Windows worker node.

Signed-off-by: Rui Cao <rcao@vmware.com>
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
@antoninbas @GraysonWu
Fix YAML syntax in "Upload assets to release" workflow (antrea-io#1072)
a146863 
Github is reporting that the syntax introduced by
antrea-io#1061 is not correct, so the
workflow cannot run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoninbas antoninbas antoninbas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Antrea v0.9.0 release
Development

Successfully merging this pull request may close these issues.
4 participants
@ruicao93 @antrea-bot @antoninbas @vmwclabot