Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support noEncap mode on Windows #1632

Closed
anfernee opened this issue Dec 8, 2020 · 2 comments · Fixed by #2160
Closed

Support noEncap mode on Windows #1632

anfernee opened this issue Dec 8, 2020 · 2 comments · Fixed by #2160
Assignees
Labels
area/OS/windows Issues or PRs related to the Windows operating system. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@anfernee
Copy link
Contributor

anfernee commented Dec 8, 2020

Describe the problem/challenge you have
Running antrea-agent with option TrafficEncapMode: NoEncap will fail with the error:

F1208 05:08:06.203391   11180 main.go:55] Failed to validate: unsupported features on Windows: {TrafficEncapMode: NoEncap}

Describe the solution you'd like
NoEncap mode also works on windows

Anything else you would like to add?
This gives the feature parity to Linux nodes. It will be useful for customers that don't like the performance penalty of an additional tunnel, as well as the MTU implication.

@anfernee anfernee added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 8, 2020
@ruicao93 ruicao93 added the area/OS/windows Issues or PRs related to the Windows operating system. label Dec 21, 2020
@ruicao93
Copy link
Contributor

Thanks Yongkun for your report. NoEncap mode support on Windows is indeed high priority.

We're working on that but is blocked by an OVS issue: openvswitch/ovs-issues#197

Will address the issue soon with OVS team.

@anfernee
Copy link
Contributor Author

Thanks @ruicao93 Do you have a rough estimation when it can be done?

lzhecheng added a commit to lzhecheng/antrea that referenced this issue May 26, 2021
This PR implements support for Windows Noencap mode. It also includes flow optimization to improve
Pod to Pod performance.

The old PR antrea-io#1901
Fixed issue antrea-io#1632

Signed-off-by: Zhecheng Li <lzhecheng@vmware.com>
lzhecheng added a commit to lzhecheng/antrea that referenced this issue May 26, 2021
This PR implements support for Windows Noencap mode. It also includes flow optimization to improve
Pod to Pod performance.
Noencap: If same subnet, destination MAC in OVS is set with peer Node annotation. If not, host routing will
be used to forward traffic.
Hybrid: If same subnet, same as Noencap with same subnet. If not, same as Encap mode.

The old PR antrea-io#1901
Fixed issue antrea-io#1632

Signed-off-by: Zhecheng Li <lzhecheng@vmware.com>
antoninbas pushed a commit that referenced this issue May 27, 2021
This PR implements support for Windows Noencap mode. It also includes flow optimization to improve
Pod to Pod performance.
Noencap: If same subnet, destination MAC in OVS is set with peer Node annotation. If not, host routing will
be used to forward traffic.
Hybrid: If same subnet, same as Noencap with same subnet. If not, same as Encap mode.

Supersedes #1901
Fixes #1632

Signed-off-by: Zhecheng Li <lzhecheng@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/OS/windows Issues or PRs related to the Windows operating system. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants