Aliaksandr_Zakharevich #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
ок, разберем про события на занятии |
| background-color: #f9f9f9; | ||
| width: 100%; | ||
| color: black; | ||
| } |
Owner
There was a problem hiding this comment.
add empty line plaese between styles
|
|
||
| const pushTodoList = () =>{ | ||
| const main = document.querySelector('.main'); | ||
| if(todoArray.length > 0) { |
Owner
There was a problem hiding this comment.
const main = document.querySelector('.main');|
// empty line
if/* space */ (todoArray.length > 0) {
| </div> | ||
| </div> | ||
| `; | ||
| main.append(div); |
Owner
There was a problem hiding this comment.
Changing dom in for is a bab idea. The most freezeing operation in js at all.
Do all changes in one tag. Add everything. Ad the apped result in DOM
Comment on lines
+85
to
+88
| const label = document.querySelector(`#labelTodo${i}`); | ||
| const data = document.querySelector(`#dateTodo${i}`); | ||
| const checkBtn = document.querySelector(`#btnCompleteTodo${i}`); | ||
| label.textContent = todoArray[i].todoTheme; |
| } | ||
|
|
||
| const addTodo = () =>{ | ||
| let todoName = document.querySelector('#inputEnter'); |
Owner
There was a problem hiding this comment.
Better to up thi variable and store in func globaly after append main layout
document.querySelector() also not so fast. Beteer to move it iutside this func
| let todoName = document.querySelector('#inputEnter'); | ||
| if(todoName.value){ | ||
| const data = new Date().toLocaleString(); | ||
| todoArray.push({todoTheme: `${todoName.value}`, data: data, isCompleted: false}) |
Owner
There was a problem hiding this comment.
In english better to name it as "topic" not a "theme". Theme is more about appearance
| const deleteAllTodo = () =>{ | ||
| const allTodo = todoArray.length; | ||
| for (let i = 0; i<allTodo; i++) { | ||
| deleteLastTodo(); |
Owner
There was a problem hiding this comment.
- you call func before declaration. Move please deleteLastTodo aboce this func.
- Why to hust set empty array and reset all data? It's musch faster
Avoid multiply document change. Always try to make one change
Comment on lines
+120
to
+126
| const lastTodo = document.querySelector(`.todo${num}`); | ||
| lastTodo.remove(); | ||
| if(todoArray[num].isCompleted){ | ||
| isCompleted(num); | ||
| } | ||
| todoArray.splice(num, 1); | ||
| countTodo(); |
Comment on lines
+130
to
+131
| const checkBtn = e.target; | ||
| const todo = document.querySelector(`.todo${checkBtn.id[checkBtn.id.length-1]}`) |
Comment on lines
+141
to
+155
| const countTodo = () =>{ | ||
| const labelAllTodo = document.querySelector('#labelAll'); | ||
| labelAllTodo.textContent = 'All: ' + todoArray.length; | ||
| } | ||
| const countCompleteTodo = () =>{ | ||
| const completedTodo = document.querySelector('#labelCompleted'); | ||
| completedTodo.textContent = 'Completed: ' + countCompetedTodo; | ||
| } | ||
|
|
||
| const isCompleted = (index)=>{ | ||
| const elem = todoArray[index]; | ||
| elem.isCompleted ? countCompetedTodo-- : countCompetedTodo++; | ||
| elem.isCompleted = !elem.isCompleted; | ||
| countCompleteTodo() | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Попробовал реализовать функицонал кнопок. Почти все получилось, но не знаю как правильно сделать работу кнопки удаления на конкретном todo и отображения всех/выполненных todo